Build and Api Versoining #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StaticallyTypedAnxiety
requested review from
ansermino,
austinabell,
dutterbutter and
ec2
as code owners
austinabell
reviewed
Oct 16, 2020
Comment on lines
+49
to
+50
| pub static ref BUILD_TYPE: RwLock<BuildType> = RwLock::new(BuildType::BuildDefault); | ||
| pub static ref RUNNING_NODE_TYPE: RwLock<NodeType> = RwLock::new(NodeType::Full); |
There was a problem hiding this comment.
why rwlock? Always same?
There was a problem hiding this comment.
Would be injecting/populatingthese values depending on what is being run at the current time. These contribute to the API details that would be returned
There was a problem hiding this comment.
The only point I was making here was that there is no need to wrap it in a mutex when it is never overwritten. Doesn't really matter but just no need for the overhead right now
Co-authored-by: Austin Abell <austinabell8@gmail.com>
dutterbutter
approved these changes
Oct 16, 2020
austinabell
approved these changes
Oct 20, 2020
Comment on lines
+49
to
+50
| pub static ref BUILD_TYPE: RwLock<BuildType> = RwLock::new(BuildType::BuildDefault); | ||
| pub static ref RUNNING_NODE_TYPE: RwLock<NodeType> = RwLock::new(NodeType::Full); |
There was a problem hiding this comment.
The only point I was making here was that there is no need to wrap it in a mutex when it is never overwritten. Doesn't really matter but just no need for the overhead right now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes
Other information and links