Wrap cached state in async mutex to avoid duplicate state calculation #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinabell
requested review from
ansermino,
dutterbutter and
ec2
as code owners
austinabell
requested review from
StaticallyTypedAnxiety,
RajarupanSampanthan and
timvermeulen
ec2
approved these changes
Oct 26, 2020
blockchain/state_manager/src/lib.rs
Outdated
| // mutex until the value is updated, which task `B` will await. | ||
| // | ||
| // If two tasks are computing different tipset states, they will only block computation | ||
| // when accessing/ initializing the entry in cache, not during the whole tipset calc. |
blockchain/state_manager/src/lib.rs
Outdated
|
|
||
| /// This is a cache which indexes tipsets to their calculated state. | ||
| /// The calculated state is wrapped in a mutex to avoid duplicate computation | ||
| /// of the state/ receipt root. |
StaticallyTypedAnxiety
approved these changes
Oct 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
You can test the functionality by uncommenting the full sync test and setting the RUST_LOG env variable to see logs, no duplicate tipset state calculation should happen
Reference issue to close (if applicable)
Closes #776
Other information and links