Defer bitfield decoding until its first use #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timvermeulen
requested review from
ansermino,
austinabell,
dutterbutter and
ec2
as code owners
ec2
approved these changes
Nov 5, 2020
austinabell
reviewed
Nov 5, 2020
utils/bitfield/src/unvalidated.rs
Outdated
Comment on lines
58
to
68
| impl Serialize for UnvalidatedBitField { | ||
| fn serialize<S>(&self, serializer: S) -> std::result::Result<S::Ok, S::Error> | ||
| where | ||
| S: Serializer, | ||
| { | ||
| match self { | ||
| Self::Validated(bf) => serde_bytes::serialize(&bf.to_bytes(), serializer), | ||
| Self::Unvalidated(bytes) => serde_bytes::serialize(&bytes, serializer), | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
optionally, can remove impl for this with serde untagged https://serde.rs/enum-representations.html#untagged (prob best to keep the deserialize either way)
austinabell
approved these changes
Nov 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
UnvalidatedBitFieldtype that may or may not have been validated for valid RLE+ yet. The existingBitFieldtype still represents validated bitfields only.Also adds the
bitfield::Validatetrait which is useful for when a function needs to be able to work with both validated and unvalidated bitfields.Closes #735