Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syncing regressions from #841 #873

Merged
merged 1 commit into from
Nov 30, 2020
Merged

Fix syncing regressions from #841 #873

merged 1 commit into from
Nov 30, 2020

Conversation

austinabell
Copy link
Contributor

@austinabell austinabell commented Nov 29, 2020

Summary of changes
Changes introduced in this pull request:

Regressions from #841:

  • Version getter was broken (I removed the unnecessary parts added to it, since it was very clunky and I don't know how I missed in review)
    • It was checking when the epoch == the fork epoch, not < or whatever would have been required with that setup
  • Incorrect tipsets were being passed back from getting lookback
  • If statement was wrong logic
  • getting the next tipset was not incrementing epoch by one

Mb for missing these in review and not doing a more thorough test, but this only gets caught when doing a full sync, and we can't have that test run by default on CI because of network calls necessary

Reference issue to close (if applicable)

Closes

Other information and links

@austinabell austinabell merged commit 15c0e67 into main Nov 30, 2020
@austinabell austinabell deleted the austin/lbtsbug branch November 30, 2020 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants