Update libp2p, async-std, and other deps #922
Conversation
|
Having issues with libp2p connections timing out with this new version, going to let this sit for a bit to debug. Could also just remove that version bump from this PR and revisit later, undecided. |
|
Interesting... When does it actually time out? When its trying to connect? Or when you try to send some RPC(BlockSync) req? |
When dialing trying to send rpc requests |
|
I think the issue is actually because libp2p/rust-libp2p#1867 dropped support for one-way requests (we are not responding to Hello currently) and possibly this is blocking us from being able to send chain exchange requests to that same peer. I'm going to investigate a bit more but I'm just leaning toward updating our hello response (was going to be done later anyway) and following this pattern, so we are available for future updates of the upstream request-response. I'm not sure how this translates with go-interop, since I don't believe they follow the same pattern. But potentially the connection closed would then translate to the |
austinabell
force-pushed
the
austin/depupd
branch
from
02c68af to
7c3f000
Compare
|
Going to just leave it as 0.28 update for now and open a draft PR for 0.34 changes (it's currently broken running against the go implementation) |
node/forest_libp2p/src/service.rs
Outdated
| let mplex_config = { | ||
| let mut mplex_config = mplex::MplexConfig::new(); | ||
| mplex_config.max_buffer_len(usize::MAX); | ||
| // mplex_config.set_max_buffer_size(usize::MAX); |
There was a problem hiding this comment.
Did you forget to remove this comment?
There was a problem hiding this comment.
ah ya, it was what the type changed in future libp2p version, I commented for easier switching, but #928 exists
node/forest_libp2p/src/behaviour.rs
Outdated
| /// Keeps track of Chain exchange requests to responses | ||
| #[behaviour(ignore)] | ||
| cx_request_table: HashMap<RequestId, OneShotSender<ChainExchangeResponse>>, | ||
| /// Boxed futures of responses for the |
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes
Other information and links