CBOR Stream Read in LibP2P RPC #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinabell
approved these changes
Jan 15, 2021
There was a problem hiding this comment.
ut but looks correct. Also, what was the reason for not switching the write to this as well? Not a blocking issue since the functionality will be the same, but would avoid going through the vec buffer first. Seems like it's worth to do now while we test this specifically?
| @@ -45,6 +45,8 @@ ipld_blockstore = "0.1" | |||
| async-trait = "0.1" | |||
| lazy_static = "1.4" | |||
|
|
|||
| futures_cbor_codec = { git = "https://github.com/najamelan/futures_cbor_codec", rev = "de08e31530513f993cbf5efef7311ac5194b2256" } | |||
There was a problem hiding this comment.
Did the most recent release, 0.2 not work?
There was a problem hiding this comment.
Is it because of the version bump from the commit after the release?
There was a problem hiding this comment.
Yeah. The 0.2 release is using futures-codec 0.3 whereas I wanted to use 0.4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes
Other information and links