address PR comments

ChainSafe · Sep 23, 2024 · 42aaa84 · 42aaa84
1 parent a430a3e
commit 42aaa84
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 2 deletions.
diff --git a/dot/parachain/candidate-validation/candidate_validation.go b/dot/parachain/candidate-validation/candidate_validation.go
@@ -189,6 +189,7 @@ func (cv *CandidateValidation) validateFromChainState(msg ValidateFromChainState
 		CandidateReceipt:        &msg.CandidateReceipt,
 		PoV:                     msg.Pov,
 		ExecutorParams:          msg.ExecutorParams,
+		PvfExecTimeoutKind:      msg.ExecKind,
 	}
 
 	result, err := cv.pvfHost.validate(validationTask)

diff --git a/dot/parachain/candidate-validation/candidate_validation_test.go b/dot/parachain/candidate-validation/candidate_validation_test.go
@@ -28,6 +28,7 @@ var (
 
 func createTestCandidateReceiptAndValidationCodeWParaId(t *testing.T, id uint32) (
 	parachaintypes.CandidateReceipt, parachaintypes.ValidationCode) {
+	t.Helper()
 	// this wasm was achieved by building polkadot's adder test parachain
 	runtimeFilePath := "./testdata/test_parachain_adder.wasm"
 	validationCodeBytes, err := os.ReadFile(runtimeFilePath)

diff --git a/dot/parachain/candidate-validation/worker.go b/dot/parachain/candidate-validation/worker.go
@@ -46,8 +46,6 @@ func determineTimeout(timeoutKind parachaintypes.PvfExecTimeoutKind) time.Durati
 		return 2 * time.Second
 	}
 	switch value.(type) {
-	case parachaintypes.Backing:
-		return 2 * time.Second
 	case parachaintypes.Approval:
 		return 12 * time.Second
 	default: