We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
github.com/libp2p/go-libp2p/p2p/discovery/mdns
Our current implementation (before PR #2794) is based on https://github.com/libp2p/go-libp2p/tree/644dadc30bcc712ea13ad730f50b5e8ec1b949f2/p2p/discovery/mdns_legacy
Unfortunately, mdns_legacy got removed in libp2p/go-libp2p@707100a so all releases since v0.21.0 do not have it anymore. The only alternative since is https://github.com/libp2p/go-libp2p/blob/4c74181d0dada0b4d600885285b96afee74e223d/p2p/discovery/mdns/mdns.go
mdns_legacy
Unfortunately again, this new mdns implementation will not work with our RPC test TestStableNetworkRPC with 3 nodes.
TestStableNetworkRPC
MODE=rpc go test -run ^TestStableNetworkRPC$ github.com/ChainSafe/gossamer/tests/rpc -v
This issue may be related to libp2p/go-libp2p#1333 (or not).
After #2794 is merged, we should try upgrading to the new mdns package https://github.com/libp2p/go-libp2p/blob/4c74181d0dada0b4d600885285b96afee74e223d/p2p/discovery/mdns/mdns.go and remove the code in internal/mdns (based on mdns_legacy, in order to be able to upgrade libp2p dependencies).
internal/mdns
The text was updated successfully, but these errors were encountered:
mdns
We should probably revisit this at some point since we're using a fork of the old libp2p/go-libp2p/p2p/discovery/mdns_legacy.
libp2p/go-libp2p/p2p/discovery/mdns_legacy
Sorry, something went wrong.
P1sar
No branches or pull requests
Our current implementation (before PR #2794) is based on https://github.com/libp2p/go-libp2p/tree/644dadc30bcc712ea13ad730f50b5e8ec1b949f2/p2p/discovery/mdns_legacy
Unfortunately,
mdns_legacy
got removed in libp2p/go-libp2p@707100a so all releases since v0.21.0 do not have it anymore. The only alternative since is https://github.com/libp2p/go-libp2p/blob/4c74181d0dada0b4d600885285b96afee74e223d/p2p/discovery/mdns/mdns.goUnfortunately again, this new mdns implementation will not work with our RPC test
TestStableNetworkRPC
with 3 nodes.MODE=rpc go test -run ^TestStableNetworkRPC$ github.com/ChainSafe/gossamer/tests/rpc -v
This issue may be related to libp2p/go-libp2p#1333 (or not).
After #2794 is merged, we should try upgrading to the new mdns package https://github.com/libp2p/go-libp2p/blob/4c74181d0dada0b4d600885285b96afee74e223d/p2p/discovery/mdns/mdns.go and remove the code in
internal/mdns
(based on mdns_legacy, in order to be able to upgrade libp2p dependencies).The text was updated successfully, but these errors were encountered: