chore(dot/network): use mdns instead of mdns_legacy

[qdm12]

Changes

Tests

MODE=rpc go test -run ^TestStableNetworkRPC$ github.com/ChainSafe/gossamer/tests/rpc -v

Issues

Related to #2768 and #2788

Primary Reviewer

[qdm12]

@Stebalien This PR only focuses on moving to the newer mdns package. I also tried with the latest github.com/libp2p/go-libp2p without success (on #2788).

One of the test failing is an integration test TestStableNetworkRPC running 3 nodes, and no node is found (should be 2).

To help you reproduce:

git clone --single-branch --branch qdm12/dot/network/mdns-upgrade --depth 1 https://github.com/ChainSafe/gossamer.git
cd gossamer
MODE=rpc go test -run ^TestStableNetworkRPC$ github.com/ChainSafe/gossamer/tests/rpc -v

Thank you in advance for any tips! 👍

[codecov]

Codecov Report

Merging #2794 (6da74a2) into development (4442eee) will increase coverage by 0.10%.
The diff coverage is 48.76%.

Additional details and impacted files

@@               Coverage Diff               @@
##           development    #2794      +/-   ##
===============================================
+ Coverage        51.77%   51.87%   +0.10%     
===============================================
  Files              220      219       -1     
  Lines            27764    27718      -46     
===============================================
+ Hits             14374    14379       +5     
+ Misses           12162    12113      -49     
+ Partials          1228     1226       -2     

[Stebalien]

Hm. It looks like it could be related to libp2p/go-libp2p#1333.

[Stebalien]

cc @marten-seemann

[marten-seemann]

Hm. It looks like it could be related to libp2p/go-libp2p#1333.

Not sure. Could be, but we have a similar test case in go-libp2p (some nodes discovering each other) that works fine.

[qdm12]

Thanks @marten-seemann and @Stebalien for helping out! 👍
I tried to separate each of the 3 Gossamer node launches by 1 minute, and then wait an extra 10 minutes and it still doesn't find other peers 😢 So maybe another problem?

For extra debugging information, the notifee HandlePeerFound(p peer.AddrInfo) is never called. The mdns is created though (NewMDNSService doesn't hang).

Do we have to perhaps change the libp2p host creation or change the service name string? (we use the same string(m.host.protocolID) as before for now)? Thanks!

[qdm12]

Could be, but we have a similar test case in go-libp2p (some nodes discovering each other) that works fine.

Can you point me to it please? Maybe I can spot what's missing/wrong in those code changes or our existing code.

[qdm12]

I changed this to use our own internal/mdns implementation based off libp2p's mdns_legacy. It's still using github.com/whyrusleeping/mdns under the hood, maybe upgrading to github.com/hashicorp/mdns would be nice once their race condition is fixed in hashicorp/mdns#75 but really not a necessity.

With this merged, #2788 should finally be unblocked.

[jimjbrettj]

lgtm

[github-actions]

🎉 This PR is included in version 0.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀