Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates made to gossamer for Zombienet #3205

Open
edwardmack opened this issue Apr 13, 2023 · 2 comments
Open

Updates made to gossamer for Zombienet #3205

edwardmack opened this issue Apr 13, 2023 · 2 comments

Comments

@edwardmack
Copy link
Member

Task summary

This is a list of updates made to gossamer to enable Zombienet to work without changes:

  • Added prometheus gauge substrate_process_start_time_seconds, this metric is used by zombienet to confirm the node has started. Not sure if we want metrics in gossamer that are in the substrate namespace, so consider different ways to handle this.
  • Created flag --rpc-cors that zombienet uses when starting nodes, this has not been implemented in gossamer, just the flag has been added so that gossamer will not throw an error when it sees this flag.

Other information and links

@timwu20
Copy link
Contributor

timwu20 commented Nov 22, 2023

@edwardmack is this issue still valid? Can we move it to ready status?

@edwardmack
Copy link
Member Author

@edwardmack is this issue still valid? Can we move it to ready status?

@timwu20 yes, the --rpc-cors flag has not been implemented yet for gossamer, we're still using a dummy flag as a placeholder for zombienet. We would also need to investigate the promethous gauge usage.

@P1sar P1sar removed CLI labels Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants