-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(cmd/gossamer): add aliases for cli flags #3098
Conversation
ba6a7af
to
0949378
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## development #3098 +/- ##
===============================================
- Coverage 51.62% 51.49% -0.13%
===============================================
Files 219 219
Lines 28208 28278 +70
===============================================
Hits 14561 14561
- Misses 12336 12394 +58
- Partials 1311 1323 +12 |
a32a818
to
a6f3a52
Compare
bbf28da
to
8a074d5
Compare
f846a17
to
39f0479
Compare
39f0479
to
f155b15
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we changing flags from global to local? It changes where we can place these flag in a command.
f155b15
to
72546bf
Compare
This was done because we upgraded to v2 of urfave/cli and GlobalString, etc have been deprecated. https://cli.urfave.org/migrate-v1-to-v2/#globalstring-globalbool-and-its-likes-are-deprecated I don't believe this changes where we can place these flags in a command. |
18d3436
to
8120862
Compare
450bd31
to
163977b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just the one question.
This reverts commit e84dde6.
b1c68e9
to
c21a69d
Compare
🎉 This PR is included in version 0.8.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Changes
This PR contains changes to make gossamer more congruent with polkadot CLI commands in order to enable gossamer to work with paritytech zombienet testing framework.
no-mdns
to aliasnomdns
.base-path
to aliasbasepath
rpc-port
to aliasrpcport
ws-port
to aliaswsport
node-key
which overrides the secret Ed25519 key to use for libp2pTests
Issues
Work done researching issue #2843
Primary Reviewer
@timwu20