Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(build): upgrade Go to 1.19 #2719

Merged
merged 4 commits into from
Jan 17, 2023
Merged

chore(build): upgrade Go to 1.19 #2719

merged 4 commits into from
Jan 17, 2023

Conversation

qdm12
Copy link
Contributor

@qdm12 qdm12 commented Aug 2, 2022 •
edited
Loading

Changes

  • CI uses Go 1.19
  • Dockerfiles use Go 1.19
  • go.mod uses Go 1.19
  • Readme: remove Go 1.19 incompatibility warning
  • Readme: update requirement to Go 1.19 or higher
  • Re-generate proto files to match Go 1.19 new comments format
  • Fix all comments to match Go 1.19 new comments format
  • Replace ioutil import with os
  • Fix new lint errors introduced
  • Remove old //gocyclo:ignore comment

Tests

Issues

Fixes #2768

Primary Reviewer

@EclesioMeloJunior

@qdm12 qdm12 mentioned this pull request Aug 8, 2022
Closed
@q9f q9f mentioned this pull request Aug 22, 2022
Closed
@danforbes danforbes linked an issue Aug 22, 2022 that may be closed by this pull request
Go 1.19 support #2768
Closed
@qdm12 qdm12 mentioned this pull request Sep 12, 2022
Closed
@qdm12 qdm12 mentioned this pull request Nov 7, 2022
Closed
@qdm12 qdm12 mentioned this pull request Nov 14, 2022
Merged
@qdm12 qdm12 mentioned this pull request Jan 4, 2023
Merged
@codecov
Copy link

codecov bot commented Jan 4, 2023 •
edited
Loading

Codecov Report

Merging #2719 (29bdaad) into development (c57ade6) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@               Coverage Diff               @@
##           development    #2719      +/-   ##
===============================================
+ Coverage        51.42%   51.46%   +0.04%     
===============================================
  Files              219      219              
  Lines            28009    28009              
===============================================
+ Hits             14403    14415      +12     
+ Misses           12320    12309      -11     
+ Partials          1286     1285       -1

@qdm12 qdm12 force-pushed the qdm12/build/go1.19 branch 7 times, most recently from 98b46a9 to 7642d49 Compare January 13, 2023 12:12
@qdm12 qdm12 marked this pull request as ready for review January 16, 2023 11:33
kishansagathiya
kishansagathiya reviewed Jan 17, 2023
View reviewed changes
Copy link
Contributor

@kishansagathiya kishansagathiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgrade to Go 1.19 is good.

Not directly relevant, but there are a lot of space removals, which is alright. Are they by-product of linter?

but I don't see the point of some the other changes that I have put ? on.

dot/rpc/modules/sync_state_integration_test.go Show resolved Hide resolved
lib/runtime/allocator.go Show resolved Hide resolved
lib/transaction/types.go Show resolved Hide resolved
tests/rpc/rpc_01-system_test.go Outdated Show resolved Hide resolved
@qdm12 qdm12 merged commit 7c01e8f into development Jan 17, 2023
@qdm12 qdm12 deleted the qdm12/build/go1.19 branch January 17, 2023 16:53
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 0.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EclesioMeloJunior EclesioMeloJunior EclesioMeloJunior approved these changes

@kishansagathiya kishansagathiya kishansagathiya approved these changes

@noot noot Awaiting requested review from noot

@edwardmack edwardmack Awaiting requested review from edwardmack

@timwu20 timwu20 Awaiting requested review from timwu20 timwu20 is a code owner

@jimjbrettj jimjbrettj Awaiting requested review from jimjbrettj jimjbrettj is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Go 1.19 support
3 participants
@qdm12 @kishansagathiya @EclesioMeloJunior