chore(types): add String unit tests for Digest and fix NewDigest comment #2965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qdm12
requested review from
noot,
edwardmack,
timwu20,
EclesioMeloJunior,
jimjbrettj and
kishansagathiya
as code owners
EclesioMeloJunior
requested changes
Nov 21, 2022
qdm12
force-pushed
the
qdm12/types/digesttostring
branch
from
cacec49
to
d4c0401
Compare
qdm12
force-pushed
the
qdm12/types/digesttostring
branch
from
d4c0401
to
c6b9719
Compare
qdm12
force-pushed
the
qdm12/scale/vdtv-string
branch
from
750d9ce
to
e3538f0
Compare
qdm12
force-pushed
the
qdm12/types/digesttostring
branch
from
c6b9719
to
9093241
Compare
qdm12
force-pushed
the
qdm12/scale/vdtv-string
branch
from
e3538f0
to
5ced638
Compare
qdm12
force-pushed
the
qdm12/types/digesttostring
branch
2 times, most recently
from
812728d
to
b179e8e
Compare
qdm12
force-pushed
the
qdm12/scale/vdtv-string
branch
from
5ced638
to
8b68c0a
Compare
qdm12
force-pushed
the
qdm12/types/digesttostring
branch
from
b179e8e
to
d266327
Compare
qdm12
force-pushed
the
qdm12/scale/vdtv-string
branch
from
8b68c0a
to
543a8b0
Compare
qdm12
force-pushed
the
qdm12/types/digesttostring
branch
3 times, most recently
from
d6c8cc9
to
7e745d1
Compare
|
@jimjbrettj it's now minor changes:
But I would still merge it since it hurts the soul to trash two still valid unit tests 😄 |
qdm12
changed the title
DigestToString function
timwu20
approved these changes
Jan 21, 2023
qdm12
force-pushed
the
qdm12/types/digesttostring
branch
from
7e745d1
to
87baeed
Compare
EclesioMeloJunior
approved these changes
Jan 23, 2023
|
🎉 This PR is included in version 0.8.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Sunday evening fun after getting sick of seeing horrible digest logged as some weird convoluted fields that don't make sense.
NewDigestcomment fixedTest_BlockAnnounceMessage_Stringunit test addedTest_Digest_Stringunit test addedTests
go test -run ^Test_DigestToString$ github.com/ChainSafe/gossamer/dot/typesIssues
One step towards #1945
Primary Reviewer
@EclesioMeloJunior