Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(runtimes): remove deprecated node runtimes #3177

Merged
merged 3 commits into from
Apr 4, 2023

Conversation

dimartiro
Copy link
Contributor

@dimartiro dimartiro commented Mar 27, 2023

Changes

  • Remove / replace old node runtimes
  • Use westend runtime when appropriate

Tests

make test

Issues

#3087

Primary Reviewer

@EclesioMeloJunior

@CLAassistant
Copy link

CLAassistant commented Mar 27, 2023

CLA assistant check
All committers have signed the CLA.

@dimartiro dimartiro force-pushed the diego/remove-old-nodes-runtimes branch from c4df004 to 531a629 Compare March 27, 2023 14:17
@dimartiro dimartiro marked this pull request as draft March 27, 2023 14:34
@dimartiro dimartiro force-pushed the diego/remove-old-nodes-runtimes branch 3 times, most recently from 2c763e7 to ddfd4d7 Compare March 28, 2023 14:58
@dimartiro dimartiro marked this pull request as ready for review March 28, 2023 14:58
@dimartiro dimartiro force-pushed the diego/remove-old-nodes-runtimes branch 2 times, most recently from 4130967 to aef1ec6 Compare March 28, 2023 14:59
@dimartiro dimartiro closed this Mar 28, 2023
@dimartiro dimartiro force-pushed the diego/remove-old-nodes-runtimes branch from aef1ec6 to e028a1b Compare March 28, 2023 15:00
@dimartiro dimartiro reopened this Mar 28, 2023
@dimartiro dimartiro force-pushed the diego/remove-old-nodes-runtimes branch 2 times, most recently from 26a03ca to e141e30 Compare March 28, 2023 16:17
Copy link
Contributor

@jimjbrettj jimjbrettj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just have questions about how some of the data was retrieved

@dimartiro dimartiro force-pushed the diego/remove-old-nodes-runtimes branch 2 times, most recently from 82384bb to 298a6b6 Compare March 29, 2023 01:41
@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Merging #3177 (8d03c19) into development (7c08365) will increase coverage by 0.30%.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff               @@
##           development    #3177      +/-   ##
===============================================
+ Coverage        51.45%   51.75%   +0.30%     
===============================================
  Files              221      221              
  Lines            28281    28275       -6     
===============================================
+ Hits             14551    14634      +83     
+ Misses           12410    12321      -89     
  Partials          1320     1320              

@dimartiro dimartiro requested a review from jimjbrettj March 29, 2023 13:29
@dimartiro dimartiro force-pushed the diego/remove-old-nodes-runtimes branch from 298a6b6 to 38f628a Compare March 29, 2023 13:31
Copy link
Contributor

@jimjbrettj jimjbrettj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@dimartiro dimartiro force-pushed the diego/remove-old-nodes-runtimes branch from 38f628a to bf3e092 Compare March 30, 2023 01:37
@dimartiro dimartiro force-pushed the diego/remove-old-nodes-runtimes branch from fcc7f6e to 36f9ac2 Compare March 30, 2023 15:37
@dimartiro dimartiro force-pushed the diego/remove-old-nodes-runtimes branch from 36f9ac2 to 1be5ab7 Compare March 30, 2023 16:32
@dimartiro dimartiro force-pushed the diego/remove-old-nodes-runtimes branch 2 times, most recently from d6b50c2 to 1be5ab7 Compare April 4, 2023 02:31
@dimartiro dimartiro merged commit d1e9475 into development Apr 4, 2023
@dimartiro dimartiro deleted the diego/remove-old-nodes-runtimes branch April 4, 2023 03:07
Copy link

🎉 This PR is included in version 0.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants