Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(parachain): add types #3297

Merged
merged 12 commits into from
Jun 15, 2023
Merged

feat(parachain): add types #3297

merged 12 commits into from
Jun 15, 2023

Conversation

kanishkatn
Copy link
Contributor

@kanishkatn kanishkatn commented Jun 2, 2023 •
edited
Loading

Changes

Added few parachain types needed for #3241

Breaking this out so that the subsystems could use this.

Tests

go test lib/parachain

Issues

#3186

Primary Reviewer

@kishansagathiya

@kanishkatn kanishkatn changed the base branch from development to feat/parachain June 2, 2023 08:55
jimjbrettj
jimjbrettj approved these changes Jun 2, 2023
View reviewed changes
Copy link
Contributor

@jimjbrettj jimjbrettj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small question, but overall looks good!

dimartiro
dimartiro approved these changes Jun 2, 2023
View reviewed changes
Copy link
Contributor

@dimartiro dimartiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I left only one suggestion to have all block types in the same file

lib/parachain/types.go Show resolved Hide resolved
edwardmack
edwardmack approved these changes Jun 8, 2023
View reviewed changes
Copy link
Member

@edwardmack edwardmack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great.

kishansagathiya
kishansagathiya reviewed Jun 9, 2023
View reviewed changes
lib/parachain/types.go Outdated Show resolved Hide resolved
lib/parachain/types.go Outdated Show resolved Hide resolved
lib/parachain/types.go Outdated Show resolved Hide resolved
lib/parachain/types.go Outdated Show resolved Hide resolved
lib/parachain/types.go Outdated Show resolved Hide resolved
kishansagathiya
kishansagathiya reviewed Jun 9, 2023
View reviewed changes
lib/parachain/types.go Show resolved Hide resolved
lib/parachain/types_test.go Outdated Show resolved Hide resolved
lib/parachain/types_test.go Show resolved Hide resolved
lib/parachain/types_test.go Show resolved Hide resolved
lib/parachain/types_test.go Show resolved Hide resolved
lib/parachain/types_test.go Show resolved Hide resolved
timwu20
timwu20 reviewed Jun 9, 2023
View reviewed changes
lib/parachain/types.go Show resolved Hide resolved
lib/parachain/types_test.go Outdated Show resolved Hide resolved
@kanishkatn kanishkatn mentioned this pull request Jun 9, 2023
Open
axaysagathiya
axaysagathiya previously requested changes Jun 12, 2023
View reviewed changes
lib/parachain/types.go Outdated Show resolved Hide resolved
kishansagathiya
kishansagathiya reviewed Jun 14, 2023
View reviewed changes
lib/parachain/types.go Outdated Show resolved Hide resolved
lib/parachain/types.go Outdated Show resolved Hide resolved
lib/parachain/types.go Outdated Show resolved Hide resolved
lib/parachain/types.go Outdated Show resolved Hide resolved
kanishkatn and others added 5 commits June 15, 2023 05:12
@kanishkatn @kishansagathiya
cleanup
47e895e 
Co-authored-by: Kishan Sagathiya <kishansagathiya@gmail.com>
@kanishkatn @kishansagathiya
cleanup
ff599ff 
Co-authored-by: Kishan Sagathiya <kishansagathiya@gmail.com>
@kanishkatn @kishansagathiya
cleanup
eb51610 
Co-authored-by: Kishan Sagathiya <kishansagathiya@gmail.com>
@kanishkatn @kishansagathiya
cleanup
d73691d 
Co-authored-by: Kishan Sagathiya <kishansagathiya@gmail.com>
@kanishkatn
cleanup
42f41a2
@kanishkatn kanishkatn dismissed axaysagathiya’s stale review June 15, 2023 11:55

changes have been made!

@kanishkatn kanishkatn merged commit 9a7b632 into feat/parachain Jun 15, 2023
@kanishkatn kanishkatn deleted the feat/k/parachain-types branch June 15, 2023 12:55
kishansagathiya added a commit that referenced this pull request Jun 20, 2023
@kanishkatn @kishansagathiya
feat(parachain): add types (#3297)
c3b3508 
Co-authored-by: Kishan Sagathiya <kishansagathiya@gmail.com>
kishansagathiya added a commit to kishansagathiya/gossamer that referenced this pull request Jul 4, 2023
@kanishkatn @kishansagathiya
feat(parachain): add types (ChainSafe#3297)
afad8bc 
Co-authored-by: Kishan Sagathiya <kishansagathiya@gmail.com>
kishansagathiya added a commit to kishansagathiya/gossamer that referenced this pull request Jul 4, 2023
@kanishkatn @kishansagathiya
feat(parachain): add types (ChainSafe#3297)
0ff2bac 
Co-authored-by: Kishan Sagathiya <kishansagathiya@gmail.com>
kishansagathiya added a commit that referenced this pull request Jul 12, 2023
@kanishkatn @kishansagathiya
feat(parachain): add types (#3297)
cdfd2ea 
Co-authored-by: Kishan Sagathiya <kishansagathiya@gmail.com>
kishansagathiya added a commit that referenced this pull request Jul 12, 2023
@kanishkatn @kishansagathiya
feat(parachain): add types (#3297)
d0277d1 
Co-authored-by: Kishan Sagathiya <kishansagathiya@gmail.com>
kishansagathiya added a commit that referenced this pull request Jul 14, 2023
@kanishkatn @kishansagathiya
feat(parachain): add types (#3297)
183f244 
Co-authored-by: Kishan Sagathiya <kishansagathiya@gmail.com>
kishansagathiya added a commit that referenced this pull request Jul 27, 2023
@kanishkatn @kishansagathiya
feat(parachain): add types (#3297)
e212d48 
Co-authored-by: Kishan Sagathiya <kishansagathiya@gmail.com>
kishansagathiya added a commit that referenced this pull request Aug 4, 2023
@kanishkatn @kishansagathiya
feat(parachain): add types (#3297)
a15f269 
Co-authored-by: Kishan Sagathiya <kishansagathiya@gmail.com>
kishansagathiya added a commit that referenced this pull request Aug 22, 2023
@kanishkatn @kishansagathiya
feat(parachain): add types (#3297)
836f8eb 
Co-authored-by: Kishan Sagathiya <kishansagathiya@gmail.com>
kishansagathiya added a commit that referenced this pull request Aug 22, 2023
@kanishkatn @kishansagathiya
feat(parachain): add types (#3297)
0411eda 
Co-authored-by: Kishan Sagathiya <kishansagathiya@gmail.com>
edwardmack pushed a commit that referenced this pull request Aug 30, 2023
@kanishkatn @kishansagathiya @edwardmack
feat(parachain): add types (#3297)
03a4582 
Co-authored-by: Kishan Sagathiya <kishansagathiya@gmail.com>
edwardmack pushed a commit that referenced this pull request Aug 31, 2023
@kanishkatn @kishansagathiya @edwardmack
feat(parachain): add types (#3297)
1aa683f 
Co-authored-by: Kishan Sagathiya <kishansagathiya@gmail.com>
kishansagathiya added a commit that referenced this pull request Sep 14, 2023
@kanishkatn @kishansagathiya
feat(parachain): add types (#3297)
710b03c 
Co-authored-by: Kishan Sagathiya <kishansagathiya@gmail.com>
kishansagathiya added a commit that referenced this pull request Jan 23, 2024
@kanishkatn @kishansagathiya
feat(parachain): add types (#3297)
764abf9 
Co-authored-by: Kishan Sagathiya <kishansagathiya@gmail.com>
kishansagathiya added a commit that referenced this pull request Jan 24, 2024
@kanishkatn @kishansagathiya
feat(parachain): add types (#3297)
8367dcf 
Co-authored-by: Kishan Sagathiya <kishansagathiya@gmail.com>
timwu20 pushed a commit that referenced this pull request Jun 13, 2024
@kanishkatn @kishansagathiya @timwu20
feat(parachain): add types (#3297)
ef1fca1 
Co-authored-by: Kishan Sagathiya <kishansagathiya@gmail.com>
timwu20 pushed a commit that referenced this pull request Jun 17, 2024
@kanishkatn @kishansagathiya @timwu20
feat(parachain): add types (#3297)
8a9ae61 
Co-authored-by: Kishan Sagathiya <kishansagathiya@gmail.com>
timwu20 pushed a commit that referenced this pull request Jun 20, 2024
@kanishkatn @kishansagathiya @timwu20
feat(parachain): add types (#3297)
9f213f0 
Co-authored-by: Kishan Sagathiya <kishansagathiya@gmail.com>
edwardmack pushed a commit that referenced this pull request Jun 26, 2024
@kanishkatn @kishansagathiya @edwardmack
feat(parachain): add types (#3297)
0f16264 
Co-authored-by: Kishan Sagathiya <kishansagathiya@gmail.com>
edwardmack pushed a commit that referenced this pull request Jul 12, 2024
@kanishkatn @kishansagathiya @edwardmack
feat(parachain): add types (#3297)
2475711 
Co-authored-by: Kishan Sagathiya <kishansagathiya@gmail.com>
kishansagathiya added a commit that referenced this pull request Jul 15, 2024
@kanishkatn @kishansagathiya
feat(parachain): add types (#3297)
24e8f80 
Co-authored-by: Kishan Sagathiya <kishansagathiya@gmail.com>
kishansagathiya added a commit that referenced this pull request Jul 15, 2024
@kanishkatn @kishansagathiya
feat(parachain): add types (#3297)
93fff58 
Co-authored-by: Kishan Sagathiya <kishansagathiya@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kishansagathiya kishansagathiya kishansagathiya left review comments

@jimjbrettj jimjbrettj jimjbrettj approved these changes

@axaysagathiya axaysagathiya axaysagathiya approved these changes

@edwardmack edwardmack edwardmack approved these changes

@timwu20 timwu20 timwu20 approved these changes

@dimartiro dimartiro dimartiro approved these changes

@EclesioMeloJunior EclesioMeloJunior Awaiting requested review from EclesioMeloJunior EclesioMeloJunior is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@kanishkatn @dimartiro @timwu20 @edwardmack @kishansagathiya @axaysagathiya @jimjbrettj