client(consensus/grandpa): implement finality proof logic #3589

jimjbrettj · 2023-11-17T19:51:59Z

Changes

Implement and test logic for creating and verifying grandpa finality proofs

Tests

go test ./client/consensus/grandpa

Issues

#3582

Primary Reviewer

@timwu20

client/consensus/grandpa/blockOrigin.go

client/consensus/grandpa/finality_proof.go

client/consensus/grandpa/interfaces.go

client/consensus/grandpa/justification.go

client/consensus/grandpa/authorities.go

client/consensus/grandpa/authorities_test.go

EclesioMeloJunior

Also, I noticed that the function checkMessageSignature can receive a signature that can be []byte or string, but why not set the signature type to be []byte always, and then let the caller to transform the string to []bytes?

client/consensus/grandpa/authorities.go

client/consensus/grandpa/aux_schema.go

client/consensus/grandpa/finality_proof.go

client/consensus/grandpa/finality_proof_test.go

client/consensus/grandpa/justification.go

client/consensus/grandpa/authorities_test.go

client/consensus/grandpa/finality_proof.go

client/consensus/grandpa/justification.go

client/consensus/grandpa/finality_proof.go

client/consensus/grandpa/finality_proof_test.go

Co-authored-by: Timothy Wu <tim.wu@chainsafe.io>

jimjbrettj assigned timwu20 Nov 17, 2023

jimjbrettj requested review from edwardmack, timwu20, EclesioMeloJunior, kishansagathiya, dimartiro and kanishkatn as code owners November 17, 2023 19:52

EclesioMeloJunior requested changes Nov 20, 2023

View reviewed changes

client/consensus/grandpa/blockOrigin.go Outdated Show resolved Hide resolved

client/consensus/grandpa/blockOrigin.go Outdated Show resolved Hide resolved

jimjbrettj requested a review from EclesioMeloJunior November 20, 2023 18:46

timwu20 requested changes Nov 21, 2023

View reviewed changes

jimjbrettj requested a review from timwu20 November 22, 2023 21:06

timwu20 requested changes Nov 28, 2023

View reviewed changes

client/consensus/grandpa/justification.go Outdated Show resolved Hide resolved

EclesioMeloJunior requested changes Nov 28, 2023

View reviewed changes

client/consensus/grandpa/authorities.go Outdated Show resolved Hide resolved

jimjbrettj requested review from timwu20 and EclesioMeloJunior November 28, 2023 22:38

EclesioMeloJunior reviewed Nov 29, 2023

View reviewed changes

client/consensus/grandpa/authorities.go Outdated Show resolved Hide resolved

client/consensus/grandpa/authorities.go Outdated Show resolved Hide resolved

client/consensus/grandpa/authorities.go Outdated Show resolved Hide resolved

kanishkatn reviewed Nov 30, 2023

View reviewed changes

client/consensus/grandpa/authorities_test.go Outdated Show resolved Hide resolved

EclesioMeloJunior requested changes Dec 4, 2023

View reviewed changes

client/consensus/grandpa/authorities.go Show resolved Hide resolved

timwu20 force-pushed the feat/grandpa branch from 3396fa8 to 87df026 Compare December 5, 2023 20:28

jimjbrettj requested a review from axaysagathiya as a code owner December 5, 2023 20:28

jimjbrettj and others added 10 commits December 5, 2023 15:03

squashed

e541a85

cleanup and mock

bdad002

reduce diffs

b142f03

remove block origin

cf924e5

CR feedback

0e6b428

authoritySetChangeID refactor to no longer be a vdt

8005843

wip/remove header as generic param

1684414

feedback wip/remove header as generic constraint to justification

2c5fffc

create seperate decodeGrandpaJustification

1fd250f

wip/fix decoding

33b3aaa

rebase + feedback

a170169

jimjbrettj force-pushed the jimmy/finalityProof branch from ee99f06 to a170169 Compare December 5, 2023 22:20

add license

5467402

jimjbrettj requested review from kanishkatn and EclesioMeloJunior December 5, 2023 22:23

jimjbrettj added 2 commits December 6, 2023 12:18

make wrapper around decode grandpaJustificaiton logic

ba26cfb

cleanup comments

b22a2a6

timwu20 requested changes Dec 7, 2023

View reviewed changes

jimjbrettj added 2 commits December 7, 2023 15:16

refactor authoritySetChangeID to use interface constraint

c01915d

remove copy of types containing mutex

d91434f

axaysagathiya reviewed Dec 11, 2023

View reviewed changes

client/consensus/grandpa/authorities_test.go Show resolved Hide resolved

client/consensus/grandpa/finality_proof.go Show resolved Hide resolved

client/consensus/grandpa/justification.go Show resolved Hide resolved

jimjbrettj requested review from axaysagathiya and timwu20 December 11, 2023 20:00

remove duplicate constraint in FinalityProofProvider

01de9d3

jimjbrettj force-pushed the jimmy/finalityProof branch from 7bfdf68 to 01de9d3 Compare December 11, 2023 21:11

timwu20 reviewed Dec 12, 2023

View reviewed changes

client/consensus/grandpa/finality_proof.go Outdated Show resolved Hide resolved

client/consensus/grandpa/finality_proof_test.go Show resolved Hide resolved

CR feedback

2e32df3

jimjbrettj requested a review from timwu20 December 12, 2023 23:35

EclesioMeloJunior approved these changes Dec 13, 2023

View reviewed changes

timwu20 approved these changes Dec 13, 2023

View reviewed changes

jimjbrettj force-pushed the jimmy/finalityProof branch from 10a7b5c to 2e32df3 Compare December 13, 2023 17:32

jimjbrettj merged commit 8f28c20 into feat/grandpa Dec 13, 2023
45 checks passed

jimjbrettj deleted the jimmy/finalityProof branch December 13, 2023 18:05

jimjbrettj mentioned this pull request Dec 13, 2023

feat(client/grandpa): Implement finality proof logic #3582

Closed

timwu20 added a commit that referenced this pull request Apr 18, 2024

client(consensus/grandpa): implement finality proof logic (#3589)

21f8972

Co-authored-by: Timothy Wu <tim.wu@chainsafe.io>

timwu20 added a commit that referenced this pull request Apr 19, 2024

client(consensus/grandpa): implement finality proof logic (#3589)

687ae0e

Co-authored-by: Timothy Wu <tim.wu@chainsafe.io>

timwu20 added a commit that referenced this pull request Apr 19, 2024

client(consensus/grandpa): implement finality proof logic (#3589)

ea9557e

Co-authored-by: Timothy Wu <tim.wu@chainsafe.io>

timwu20 added a commit that referenced this pull request Apr 19, 2024

client(consensus/grandpa): implement finality proof logic (#3589)

fa3fd23

Co-authored-by: Timothy Wu <tim.wu@chainsafe.io>

timwu20 added a commit that referenced this pull request Apr 19, 2024

client(consensus/grandpa): implement finality proof logic (#3589)

e85e13e

Co-authored-by: Timothy Wu <tim.wu@chainsafe.io>

timwu20 added a commit that referenced this pull request Oct 11, 2024

client(consensus/grandpa): implement finality proof logic (#3589)

6da2666

Co-authored-by: Timothy Wu <tim.wu@chainsafe.io>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

client(consensus/grandpa): implement finality proof logic #3589

client(consensus/grandpa): implement finality proof logic #3589

jimjbrettj commented Nov 17, 2023

EclesioMeloJunior left a comment •

edited

Loading

client(consensus/grandpa): implement finality proof logic #3589

client(consensus/grandpa): implement finality proof logic #3589

Conversation

jimjbrettj commented Nov 17, 2023

Changes

Tests

Issues

Primary Reviewer

EclesioMeloJunior left a comment • edited Loading

Choose a reason for hiding this comment

EclesioMeloJunior left a comment •

edited

Loading