-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(lib/sync): introduce fullsync
strategy
#4114
Merged
Merged
+2,770
−6,792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EclesioMeloJunior
requested review from
jimjbrettj,
timwu20 and
kishansagathiya
as code owners
August 6, 2024 22:25
… into eclesio/sync-strategy
jimjbrettj
reviewed
Aug 12, 2024
jimjbrettj
reviewed
Aug 12, 2024
jimjbrettj
reviewed
Aug 12, 2024
jimjbrettj
reviewed
Aug 12, 2024
jimjbrettj
reviewed
Aug 12, 2024
haikoschol
approved these changes
Sep 24, 2024
… into eclesio/sync-strategy
… into eclesio/sync-strategy
timwu20
reviewed
Sep 26, 2024
timwu20
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few small comments. Great work @EclesioMeloJunior!
jimjbrettj
reviewed
Sep 30, 2024
jimjbrettj
reviewed
Sep 30, 2024
jimjbrettj
reviewed
Sep 30, 2024
jimjbrettj
approved these changes
Sep 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gave another look over, looks great! Few minor comments but you can use your discretion if you want to accept them or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
dot/sync
packagelib/sync
bootstrap
andtip
sync and just uses thefullsync
as the default strategySyncService
uses the strategy approach as described in Refactor sync package to use the strategy approach #4112Tests
go test -timeout 10m github.com/ChainSafe/gossamer/lib/sync --tags=integration -v
Issues