Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dot/network): Add warp sync request handler #4186

Merged
merged 21 commits into from
Sep 25, 2024
Merged

feat(dot/network): Add warp sync request handler #4186

merged 21 commits into from
Sep 25, 2024

Conversation

dimartiro
Copy link
Contributor

@dimartiro dimartiro commented Sep 18, 2024 •
edited
Loading

Changes

Adds warp sync request handler.

  • Register warp sync handler at /sync/warp
  • Added request message encoding / decoding
  • Add handler to respond to warp sync requests
  • tests

This implementation is slightly different from the one proposed in #4052, but I think it's more straightforward and less complex, which will help us achieve a quick warp sync implementation. We can discuss or revisit this later.

Tests

go test ./dot/network

Issues

closing: #4052

@dimartiro dimartiro self-assigned this Sep 18, 2024
@dimartiro dimartiro linked an issue Sep 18, 2024 that may be closed by this pull request
Implement warp sync request handler #4052
Closed
3 tasks
@dimartiro dimartiro changed the base branch from eclesio/sync-strategy to development September 18, 2024 19:23
dimartiro
dimartiro commented Sep 18, 2024
View reviewed changes
dot/network/service.go Outdated Show resolved Hide resolved
@dimartiro dimartiro marked this pull request as ready for review September 18, 2024 20:19
EclesioMeloJunior
EclesioMeloJunior reviewed Sep 19, 2024
View reviewed changes
dot/network/warp_sync.go Outdated Show resolved Hide resolved
dot/network/warp_sync.go Outdated Show resolved Hide resolved
dot/network/warp_sync.go Show resolved Hide resolved
EclesioMeloJunior
EclesioMeloJunior approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@EclesioMeloJunior EclesioMeloJunior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dot/network/service.go Outdated Show resolved Hide resolved
jimjbrettj
jimjbrettj reviewed Sep 20, 2024
View reviewed changes
dot/network/config.go Outdated Show resolved Hide resolved
jimjbrettj
jimjbrettj approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@jimjbrettj jimjbrettj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small questions/comments, but overall great work and LGTM!

@dimartiro dimartiro merged commit 2fdf95a into development Sep 25, 2024
24 checks passed
@dimartiro dimartiro deleted the diego/warp-sync-req_handler branch September 25, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimjbrettj jimjbrettj jimjbrettj approved these changes

@EclesioMeloJunior EclesioMeloJunior EclesioMeloJunior approved these changes

@timwu20 timwu20 Awaiting requested review from timwu20 timwu20 is a code owner

@kishansagathiya kishansagathiya Awaiting requested review from kishansagathiya kishansagathiya is a code owner

Assignees

@dimartiro dimartiro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement warp sync request handler
3 participants
@dimartiro @EclesioMeloJunior @jimjbrettj