Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lib/grandpa): Add warp sync provider #4187

Merged
merged 21 commits into from
Oct 2, 2024
Merged

feat(lib/grandpa): Add warp sync provider #4187

merged 21 commits into from
Oct 2, 2024

Conversation

dimartiro
Copy link
Contributor

@dimartiro dimartiro commented Sep 18, 2024 •
edited
Loading

Changes

Adds warp sync provider to generate warp sync proofs as part of lib/grandpa

  • Modify database.Table to implement NewPrefixIterator method
  • Create isolated BlockState and GrandpaState interface with the required methods
  • Implement warp sync proof generation
  • Tests

Tests

make test

Issues

closes: #4053

@dimartiro dimartiro changed the title [WIP] feat(lib/grandpa): Add warp sync provider feat(lib/grandpa): Add warp sync provider Sep 23, 2024
@dimartiro dimartiro marked this pull request as ready for review September 26, 2024 02:16
@dimartiro dimartiro force-pushed the diego/warp-sync-provider branch 2 times, most recently from 2539107 to 1a250c6 Compare September 26, 2024 14:24
haikoschol
haikoschol requested changes Oct 1, 2024
View reviewed changes
dot/state/grandpa.go Outdated Show resolved Hide resolved
dot/state/grandpa.go Outdated Show resolved Hide resolved
internal/client/consensus/grandpa/warp_sync.go Outdated Show resolved Hide resolved
internal/client/consensus/grandpa/warp_sync.go Show resolved Hide resolved
internal/client/consensus/grandpa/warp_sync.go Outdated Show resolved Hide resolved
jimjbrettj
jimjbrettj reviewed Oct 1, 2024
View reviewed changes
Copy link
Contributor

@jimjbrettj jimjbrettj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments, but overall really nice work!

@dimartiro dimartiro force-pushed the diego/warp-sync-provider branch 3 times, most recently from 1edb73b to c78830d Compare October 1, 2024 15:18
jimjbrettj
jimjbrettj approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@jimjbrettj jimjbrettj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great work here!

EclesioMeloJunior
EclesioMeloJunior approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@EclesioMeloJunior EclesioMeloJunior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work @dimartiro!

@dimartiro dimartiro merged commit 6a833fd into development Oct 2, 2024
24 checks passed
@dimartiro dimartiro deleted the diego/warp-sync-provider branch October 2, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimjbrettj jimjbrettj jimjbrettj approved these changes

@EclesioMeloJunior EclesioMeloJunior EclesioMeloJunior approved these changes

@haikoschol haikoschol haikoschol approved these changes

@timwu20 timwu20 Awaiting requested review from timwu20 timwu20 is a code owner

@kishansagathiya kishansagathiya Awaiting requested review from kishansagathiya kishansagathiya is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement warp sync provider
4 participants
@dimartiro @haikoschol @EclesioMeloJunior @jimjbrettj