decode messages to wire message #4188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
collation protocol and validation protocol uses messages wrapped as wiremessage. So we had to adjust our decoder and handler functions according to that. Apart from this I have also added message type to wire message struct. Since wire message could be collation message or validation message, I have chose to manually set this as a value instead of returning a hardcoded value.
kishansagathiya
requested review from
EclesioMeloJunior,
jimjbrettj and
timwu20
as code owners
edwardmack
approved these changes
Oct 1, 2024
axaysagathiya
approved these changes
Oct 1, 2024
EclesioMeloJunior
approved these changes
Oct 1, 2024
kishansagathiya
merged commit 8850115
into
kishan/feat/network-bridge-rx
21 of 22 checks passed
kishansagathiya
added a commit
that referenced
this pull request
Oct 4, 2024
- handled active leaves update message - handled block finalized message - relay network protocol messages - handle view update message for receiver side of the network bridge #3864 - decode messages to wire message (PR #4188), Fixes #4108 - handle our view change in collator protocol validator side (PR #4197), Issue #4156 - Handle network bridge messages (UpdateAuthorityIDs and NewGossipTopology) Fixes #3862 - process network events for receiver side of network bridge Issue Fixes #3863 - process overseer signals for network bridge Fixes #3861
edwardmack
added a commit
that referenced
this pull request
Oct 4, 2024
statement distribution skeleton (#4169) Statement Distribution subsystem is responsible for distributing signed statements that we have generated and forwarding statements generated by our peers. This commit just introduces a skeleton for it. - implements the subsystem interface - registers the subsystem with overseer - add the processMessage method with messages to be handled Issue #3583 cleanup remove un-used code add comments regenerate mocks feat(dot/parachain): receiver side of network bridge (#3955) - handled active leaves update message - handled block finalized message - relay network protocol messages - handle view update message for receiver side of the network bridge #3864 - decode messages to wire message (PR #4188), Fixes #4108 - handle our view change in collator protocol validator side (PR #4197), Issue #4156 - Handle network bridge messages (UpdateAuthorityIDs and NewGossipTopology) Fixes #3862 - process network events for receiver side of network bridge Issue Fixes #3863 - process overseer signals for network bridge Fixes #3861
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
collation protocol and validation protocol uses messages wrapped as wiremessage. So we had to adjust our decoder and handler functions according to that.
Apart from this I have also added message type to wire message struct. Since wire message could be collation message or validation message, I have chose to manually set this as a value instead of returning a hardcoded value.
Changes
Tests
go test -tags integration github.com/ChainSafe/gossamerIssues
#4108