Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update pubsub interface to run subsystem tests #148

Merged

Conversation

vasco-santos
Copy link
Collaborator

@vasco-santos vasco-santos commented Jan 21, 2021

This PR updates libp2p interfaces to run all pubsub subsystem tests, moving the ownership of libp2p tests to the modules. Context: libp2p/js-libp2p#857

Note that the changes in the generated protobuf file are from the new patch of protobufjs

Needs:

@vasco-santos vasco-santos force-pushed the chore/update-pubsub-interface-with-integration-tests branch 2 times, most recently from 0a64c01 to bc18618 Compare January 21, 2021 13:57
@codecov-io
Copy link

codecov-io commented Jan 21, 2021

Codecov Report

Merging #148 (bc18618) into master (12626e8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #148   +/-   ##
=======================================
  Coverage   92.00%   92.00%           
=======================================
  Files           2        2           
  Lines          25       25           
=======================================
  Hits           23       23           
  Misses          2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12626e8...bc18618. Read the comment docs.

@stale
Copy link

stale bot commented Mar 19, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the bot:stale label Mar 19, 2021
@vasco-santos vasco-santos force-pushed the chore/update-pubsub-interface-with-integration-tests branch from bc18618 to bc12a84 Compare May 25, 2021 11:55
@stale stale bot removed the bot:stale label May 25, 2021
@vasco-santos vasco-santos marked this pull request as ready for review May 27, 2021 09:15
@codecov-commenter
Copy link

codecov-commenter commented May 27, 2021

Codecov Report

Merging #148 (60191ee) into master (966bd47) will increase coverage by 4.29%.
The diff coverage is 87.77%.

❗ Current head 60191ee differs from pull request most recent head ee2d5ae. Consider uploading reports for the commit ee2d5ae to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #148      +/-   ##
==========================================
+ Coverage   72.29%   76.58%   +4.29%     
==========================================
  Files           2        2              
  Lines        1776     1905     +129     
  Branches      141      140       -1     
==========================================
+ Hits         1284     1459     +175     
+ Misses        492      446      -46     
Impacted Files Coverage Δ
ts/message/rpc.js 76.49% <87.77%> (+4.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 966bd47...ee2d5ae. Read the comment docs.

@vasco-santos vasco-santos force-pushed the chore/update-pubsub-interface-with-integration-tests branch from 60191ee to ee2d5ae Compare May 27, 2021 11:36
@vasco-santos vasco-santos requested a review from wemeetagain May 27, 2021 11:58
@vasco-santos vasco-santos changed the title chore: update pubsub interface to run integration tests chore: update pubsub interface to run subsystem tests May 27, 2021
@vasco-santos vasco-santos merged commit 5356be5 into master May 28, 2021
@vasco-santos vasco-santos deleted the chore/update-pubsub-interface-with-integration-tests branch May 28, 2021 11:47
vasco-santos added a commit that referenced this pull request May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants