chore: increase the default for seenTTL to match that of go-libp2p #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the go implementation of gossipsub, libp2p keeps a 2 minute long cache of recently seen pubsub messages so that the node won't forward on duplicate messages. In the JS implementation the default seen cache ttl is only 30 seconds. We have seen issues with duplicate pubsub messages (see libp2p/js-libp2p#1043) and think this shorter cache ttl may be part of the problem. In any case it would be good for the default behavior to be consistent between the javascript and go implementation