Skip to content

Conversation

@John-LittleBearLabs
Copy link
Contributor

No description provided.

@John-LittleBearLabs John-LittleBearLabs requested a review from a team as a code owner August 5, 2022 06:37
@CLAassistant
Copy link

CLAassistant commented Aug 5, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@achingbrain achingbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending the comments.

Please can you add a test?

@mpetrunic
Copy link
Member

@John-LittleBearLabs @ckousik Are you guys use noise pipes option (IK and XXFallback handshakes)?

@ckousik
Copy link

ckousik commented Aug 5, 2022

@John-LittleBearLabs @ckousik Are you guys use noise pipes option (IK and XXFallback handshakes)?

No, we are not using that option. We are using the XX handshake by default.

@John-LittleBearLabs
Copy link
Contributor Author

@achingbrain

Please can you add a test?

Added a test

@wemeetagain
Copy link
Member

@John-LittleBearLabs looks like linter is still complaining https://github.com/ChainSafe/js-libp2p-noise/runs/7732868911?check_suite_focus=true#step:5:11

@John-LittleBearLabs
Copy link
Contributor Author

@wemeetagain

@John-LittleBearLabs looks like linter is still complaining https://github.com/ChainSafe/js-libp2p-noise/runs/7732868911?check_suite_focus=true#step:5:11

Yeah sorry about that. Addressing it.

@mpetrunic mpetrunic merged commit 15f7a6e into ChainSafe:master Aug 10, 2022
@mpetrunic mpetrunic linked an issue Aug 11, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow callers to optionally specify the prologue

6 participants