fix!: update stream types #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libp2p streams are now explicit about the types of sync/sources they provide, showing that they are `AsyncGenerator`s and not just `AsyncIterable`s. Refs: achingbrain/it-stream-types#45 BREAKING CHANGE: the type of the source/sink properties have changed
|
@achingbrain it seems the interop test is failing |
|
I believe Interop tests will be broken until the next version of js-libp2p is released |
wemeetagain
previously approved these changes
May 2, 2023
Signed-off-by: Marin Petrunic <marin.petrunic@gmail.com>
|
@achingbrain Seems like go-libp2p in interop tests doesn't support mplex by default. I enabled yamux on js libp2p in this tests so it works but when debugging, go peer doesn't list mplex as supported protocol |
mpetrunic
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libp2p streams are now explicit about the types of sync/sources they provide, showing that they are
AsyncGenerators and not justAsyncIterables.Refs: achingbrain/it-stream-types#45
BREAKING CHANGE: the type of the source/sink properties have changed