chore: update deps and specify root for pbjs #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updates all deps to pull in the latest buffer and bl modules - Specifies a root name for pbjs code gen - message names for pbjs generated code are global so specifying a root name scopes them to prevent two modules accidentally trampling over each other's protobuf code by giving their messages the same name Refs: ipfs/js-ipfs-bitswap#323 BREAKING CHANGE: buffer@6 dropped support for IE and Safari < 10
Codecov Report
@@ Coverage Diff @@
## master #94 +/- ##
==========================================
- Coverage 89.90% 89.09% -0.81%
==========================================
Files 16 16
Lines 1773 1807 +34
Branches 238 239 +1
==========================================
+ Hits 1594 1610 +16
- Misses 179 197 +18
Continue to review full report at Codecov.
|
77 tasks
vasco-santos
approved these changes
Apr 26, 2021
mpetrunic
approved these changes
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generated code are global so specifying a root name scopes them
to prevent two modules accidentally trampling over each other's
protobuf code by giving their messages the same name
Refs: ipfs/js-ipfs-bitswap#323
BREAKING CHANGE: buffer@6 dropped support for IE and Safari < 10