processBlocks for 4844 blocks. Do not compute aggregate proof for emp…

…ty array (it crashes)
ChainSafe · Nov 8, 2022 · 656b7d3 · 656b7d3
1 parent aee7d95
commit 656b7d3
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 3 deletions.
diff --git a/packages/beacon-node/src/api/impl/beacon/blocks/index.ts b/packages/beacon-node/src/api/impl/beacon/blocks/index.ts
@@ -204,13 +204,25 @@ export function getBeaconBlockApi({
     },
 
     async publishBlockWithBlobs(signedBeaconBlockAndBlobsSidecar) {
-      const {message} = signedBeaconBlockAndBlobsSidecar.beaconBlock;
+      const {beaconBlock} = signedBeaconBlockAndBlobsSidecar;
+      const {message} = beaconBlock;
+
       const seenTimestampSec = Date.now() / 1000;
       await waitForSlot(message.slot);
 
       metrics?.registerBeaconBlock(OpSource.api, seenTimestampSec, message);
 
-      await Promise.all([network.gossip.publishSignedBeaconBlockAndBlobsSidecar(signedBeaconBlockAndBlobsSidecar)]);
+      await Promise.all([
+        network.gossip.publishSignedBeaconBlockAndBlobsSidecar(signedBeaconBlockAndBlobsSidecar),
+        // TODO EIP-4844 processBlock for signedBeaconBlockAndBlobsSidecar
+        // We need to save the blob?
+        chain.processBlock(beaconBlock).catch((e) => {
+          if (e instanceof BlockError && e.type.code === BlockErrorCode.PARENT_UNKNOWN) {
+            network.events.emit(NetworkEvent.unknownBlockParent, beaconBlock, network.peerId.toString());
+          }
+          throw e;
+        }),
+      ]);
     },
   };
 }
diff --git a/packages/validator/src/services/block.ts b/packages/validator/src/services/block.ts
@@ -138,7 +138,13 @@ export class BlockProposingService {
     blobsSidecar.beaconBlockRoot = blindedOrFullBlockHashTreeRoot(this.config, block);
     blobsSidecar.beaconBlockSlot = block.slot;
     blobsSidecar.blobs = blobs;
-    blobsSidecar.kzgAggregatedProof = computeAggregateKzgProof(blobs);
+
+    // c-kzg throws an error:
+    //   free(): invalid next size (fast)
+    // when computeAggregateKzgProof is called with [] blobs
+    blobsSidecar.kzgAggregatedProof = blobs.length
+      ? computeAggregateKzgProof(blobs)
+      : ssz.eip4844.KZGProof.defaultValue();
 
     return blobsSidecar;
   }