Enable recomended rule performance/noAccumulatingSpread

ChainSafe · Oct 11, 2024 · 91f6054 · 91f6054
1 parent ab71719
commit 91f6054
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 8 deletions.
diff --git a/biome.jsonc b/biome.jsonc
@@ -52,11 +52,9 @@
           }
         },
         "useArrayLiterals": "error",
-        "noUndeclaredDependencies": "off", // TODO: Need to see why this rule is not detecting monorepo packages
         "noUndeclaredVariables": "error"
       },
       "performance": {
-        "noAccumulatingSpread": "off",
         "noDelete": "off"
       },
       "style": {

diff --git a/packages/cli/src/options/paramsOptions.ts b/packages/cli/src/options/paramsOptions.ts
@@ -25,14 +25,14 @@ export function parseBeaconParamsArgs(args: Record<string, string | number>): IB
 }
 
 const paramsOptionsByName = ObjectKeys(chainConfigTypes).reduce(
-  (options: Record<string, CliOptionDefinition>, key): Record<string, CliOptionDefinition> => ({
-    ...options,
-    [getArgKey(key)]: {
+  (options: Record<string, CliOptionDefinition>, key): Record<string, CliOptionDefinition> => {
+    options[getArgKey(key)] = {
       hidden: true,
       type: "string",
       group: "params",
-    },
-  }),
+    };
+    return options;
+  },
   {}
 );
 

diff --git a/packages/cli/test/utils/crucible/utils/paths.ts b/packages/cli/test/utils/crucible/utils/paths.ts
@@ -84,5 +84,11 @@ export const getNodeMountedPaths = <T extends ExecutionPaths | BeaconPaths | Val
       [`${key}Mounted`, mount ? (value as string).replace(paths.rootDir, mountPath) : value],
     ])
     .flat()
-    .reduce((o, [key, value]) => ({...o, [key]: value as string}), {}) as MountedPaths<T>;
+    .reduce(
+      (o, [key, value]) => {
+        o[key] = value as string;
+        return o;
+      },
+      {} as Record<string, string>
+    ) as MountedPaths<T>;
 };