Prune producedBlobsSidecarCache

ChainSafe · Nov 27, 2022 · ccdb9bb · ccdb9bb
1 parent ebf0eae
commit ccdb9bb
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 2 deletions.
diff --git a/packages/beacon-node/src/chain/chain.ts b/packages/beacon-node/src/chain/chain.ts
@@ -16,9 +16,9 @@ import {IBeaconConfig} from "@lodestar/config";
 import {allForks, UintNum64, Root, phase0, eip4844, Slot, RootHex, Epoch, ValidatorIndex} from "@lodestar/types";
 import {CheckpointWithHex, ExecutionStatus, IForkChoice, ProtoBlock} from "@lodestar/fork-choice";
 import {ProcessShutdownCallback} from "@lodestar/validator";
-import {ILogger, toHex} from "@lodestar/utils";
+import {ILogger, pruneSetToMax, toHex} from "@lodestar/utils";
 import {CompositeTypeAny, fromHexString, TreeView, Type} from "@chainsafe/ssz";
-import {SLOTS_PER_EPOCH} from "@lodestar/params";
+import {ForkSeq, SLOTS_PER_EPOCH} from "@lodestar/params";
 
 import {GENESIS_EPOCH, ZERO_HASH} from "../constants/index.js";
 import {IBeaconDb} from "../db/index.js";
@@ -65,6 +65,9 @@ import {BlobsResultType, BlockAttributes, produceBlockBody} from "./produceBlock
 import {computeNewStateRoot} from "./produceBlock/computeNewStateRoot.js";
 import {BlockImport} from "./blocks/types.js";
 
+const DEFAULT_MAX_CACHED_BLOBS_SIDECAR = 8;
+const MAX_RETAINED_SLOTS_CACHED_BLOBS_SIDECAR = 8;
+
 export class BeaconChain implements IBeaconChain {
   readonly genesisTime: UintNum64;
   readonly genesisValidatorsRoot: Root;
@@ -394,6 +397,10 @@ export class BeaconChain implements IBeaconChain {
         blobs: blobs.blobs,
         kzgAggregatedProof: computeAggregateKzgProof(blobs.blobs),
       });
+      pruneSetToMax(
+        this.producedBlobsSidecarCache,
+        this.opts.maxCachedBlobsSidecar ?? DEFAULT_MAX_CACHED_BLOBS_SIDECAR
+      );
     }
 
     return block;
@@ -630,6 +637,15 @@ export class BeaconChain implements IBeaconChain {
         this.logger.error("Error on exchangeTransitionConfiguration", {}, e as Error);
       });
     }
+
+    // Prune old blobsSidecar for block production, those are only useful on their slot
+    if (this.config.getForkSeq(slot) >= ForkSeq.eip4844 && this.producedBlobsSidecarCache.size > 0) {
+      for (const [key, blobsSidecar] of this.producedBlobsSidecarCache) {
+        if (slot > blobsSidecar.beaconBlockSlot + MAX_RETAINED_SLOTS_CACHED_BLOBS_SIDECAR) {
+          this.producedBlobsSidecarCache.delete(key);
+        }
+      }
+    }
   }
 
   private onClockEpoch(epoch: Epoch): void {

diff --git a/packages/beacon-node/src/chain/options.ts b/packages/beacon-node/src/chain/options.ts
@@ -21,6 +21,7 @@ export type IChainOptions = BlockProcessOpts &
     /** Number of missed slots allowed in the faultInspectionWindow for builder circuit*/
     allowedFaults?: number;
     sanityCheckExecutionEngineBlocks?: boolean;
+    maxCachedBlobsSidecar?: number;
   };
 
 export type BlockProcessOpts = {