Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move API consumer code to chain class #2491

Closed
dapplion opened this issue May 5, 2021 · 4 comments · Fixed by #5572
Closed

Move API consumer code to chain class #2491

dapplion opened this issue May 5, 2021 · 4 comments · Fixed by #5572
Labels
prio-medium Resolve this some time soon (tm). scope-none Issues that do not fit within any of the other defined scopes.

Comments

@dapplion
Copy link
Contributor

dapplion commented May 5, 2021

Feature request

Basic ops like getBlock or getState and not clearly defined in Lodestar. The code in the API to do that could be moved to BeaconChain class so it can be consumed programatically from there too
@stale
Copy link

stale bot commented Jul 8, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta-stale Label for stale issues applied by the stale bot. label Jul 8, 2021
@3xtr4t3rr3str14l
Copy link
Contributor

3xtr4t3rr3str14l commented Jul 8, 2021 •
edited
Loading

@dapplion i guess since these ops have been moved to the lodestar-api package that we can close this issue?

@stale stale bot removed the meta-stale Label for stale issues applied by the stale bot. label Jul 8, 2021
@dapplion
Copy link
Contributor Author

dapplion commented Jul 8, 2021

@dapplion i guess since these ops have been moved to the lodestar-api package that we can close this issue?

No, this issue is about moving the code from api/impl to chain

@stale
Copy link

stale bot commented Sep 7, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta-stale Label for stale issues applied by the stale bot. label Sep 7, 2021
@dapplion dapplion added the prio-medium Resolve this some time soon (tm). label Sep 9, 2021
@stale stale bot removed the meta-stale Label for stale issues applied by the stale bot. label Sep 9, 2021
@q9f q9f added mod4-api and removed mod4-api labels Sep 14, 2021
@philknows philknows added the scope-none Issues that do not fit within any of the other defined scopes. label Sep 8, 2022
This was referenced May 29, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
prio-medium Resolve this some time soon (tm). scope-none Issues that do not fit within any of the other defined scopes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: move state getter from API impl to chain ChainSafe/lodestar
4 participants
@3xtr4t3rr3str14l @dapplion @philknows @q9f