-
-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: move block getter from API impl to chain #5570
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapplion
changed the title
Move block getter from API impl to chain
refactor: move block getter from API impl to chain
May 29, 2023
Performance Report✔️ no performance regression detected Full benchmark results
|
dapplion
force-pushed
the
dapplion/block-api-to-chain
branch
from
May 29, 2023 18:51
a75bd57
to
c3f44d4
Compare
dapplion
force-pushed
the
dapplion/block-api-to-chain
branch
from
May 31, 2023 09:49
2fdc823
to
60c776f
Compare
wemeetagain
approved these changes
May 31, 2023
🎉 This PR is included in v1.9.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Our strategy to store blocks in not trivial and should be managed by the chain class not the API impl. The API impl should be concerned only with resolving the request payload and then forwarding to the chain.
Description
Chain exposes two methods for it
An edge case important to note is what happens if an archive operation happens during a getBlock request. In the future we may want to have a lock mechanism on during archiving, which will be handled by the chain class
Move block getter from API impl to chain