Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releases not uploaded to Dockerhub #2999

Closed
dapplion opened this issue Aug 24, 2021 · 4 comments · Fixed by #3006
Closed

Releases not uploaded to Dockerhub #2999

dapplion opened this issue Aug 24, 2021 · 4 comments · Fixed by #3006
Assignees
Labels
prio-high Resolve issues as soon as possible.

Comments

@dapplion
Copy link
Contributor

dapplion commented Aug 24, 2021

Describe the bug

At least version 0.28.0 is not uploaded to Dockerhub. The publish to Dockerhub action failed. https://github.com/ChainSafe/lodestar/runs/3255490028

Step 5/12 : ENV VERSION=$VERSION
 ---> Running in ce678a409691
Removing intermediate container ce678a409691
 ---> 47fbf0c68360
Step 6/12 : RUN npm install @chainsafe/lodestar-cli@$VERSION
 ---> Running in eade1e96c7d9
npm ERR! code ETARGET
npm ERR! notarget No matching version found for @chainsafe/lodestar-cli@0.28.0.
npm ERR! notarget In most cases you or one of your dependencies are requesting
npm ERR! notarget a package version that doesn't exist.

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2021-08-05T18_50_04_526Z-debug.log
The command '/bin/sh -c npm install @chainsafe/lodestar-cli@$VERSION' returned a non-zero code: 1

I think the problem is a race condition with NPM. We have a prior action that uploads that version to NPM, then run the Dockerfile that installs from NPM. Since the timing is tight, it may happen that NPM doesn't acknowledge the existence of that version.

Expected behavior

All releases should be uploaded to Dockerhub

@q9f q9f self-assigned this Aug 24, 2021
@q9f
Copy link
Contributor

q9f commented Aug 24, 2021

It stopped working 2 months ago apparently but the nightly builds still make it to Docker hub. I'll check the scripts.

@q9f
Copy link
Contributor

q9f commented Aug 24, 2021

It was potentially broken in #2667 or #2672 or #2705

@q9f
Copy link
Contributor

q9f commented Aug 24, 2021

Releases are delayed for 10-15 minutes npm/npm#20056

https://npm.community/t/newly-published-packages-have-a-delay-before-they-are-consumable/952

Can't really tell why nightly is working though. (lucky us?)

@dapplion
Copy link
Contributor Author

I think the easiest solution now is to:

  1. Add a wait and pause step to ensure it's available before attempting the docker build
  2. Restructure the skip checks such that re-running the workflow still attempts to build the image again even if the tag exists. Skipping only the publish to NPM step

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio-high Resolve issues as soon as possible.
Projects
None yet
2 participants