-
-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish nightly version to Docker Hub too #2667
Conversation
Code Climate has analyzed commit ce89a1b and detected 0 issues on this pull request. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be wise to also change dockerfile to only install npm package otherwise we will spend huge amount of ci time just building that docker images
Yeah I'm on it #2672 |
Warning! There can be a race condition if NPM does not serve the recently pushed version immediately. The build should target the exact version of this nightly build. We could use this API https://registry.npmjs.org/@chainsafe/lodestar-cli to ensure that our target nightly version is already available. |
Motivation
With #2647 we are releasing nightly versions to NPM. We should do the same for Docker Hub.
Description
Grab the tag from lerna's logic and publish to Docker Hub.