Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process blocks in epoch #2628

Merged
merged 2 commits into from
Jun 4, 2021
Merged

Process blocks in epoch #2628

merged 2 commits into from
Jun 4, 2021

Conversation

dapplion
Copy link
Contributor

@dapplion dapplion commented Jun 3, 2021

Motivation

Duplication of logic between processBlock and processChainSegment have caused this bug #2627

Description

@codeclimate
Copy link

codeclimate bot commented Jun 3, 2021

Code Climate has analyzed commit 4cad6ea and detected 3 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1
Duplication 2

View more on Code Climate.

@dapplion dapplion changed the title Dapplion/process blocks in epoch Process blocks in epoch Jun 3, 2021
@dapplion dapplion marked this pull request as draft June 3, 2021 14:17
@dapplion dapplion force-pushed the dapplion/processBlocksInEpoch branch from 4b7b122 to 83b7da8 Compare June 3, 2021 20:19
@dapplion dapplion marked this pull request as ready for review June 3, 2021 21:05
@dapplion dapplion force-pushed the dapplion/processBlocksInEpoch branch from 83b7da8 to 4cad6ea Compare June 3, 2021 21:06
@github-actions github-actions bot added the scope-networking All issues related to networking, gossip, and libp2p. label Jun 3, 2021
@twoeths twoeths merged commit c7edae5 into master Jun 4, 2021
@twoeths twoeths deleted the dapplion/processBlocksInEpoch branch June 4, 2021 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope-networking All issues related to networking, gossip, and libp2p.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

processSyncCommittee slot bug
2 participants