Fix debug state api limitation #2633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3xtr4t3rr3str14l
requested review from
dapplion,
mpetrunic,
twoeths and
wemeetagain
as code owners
|
Code Climate has analyzed commit b4a560e and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
mpetrunic
reviewed
Jun 4, 2021
This change allows to reach the getFinalizedState() code path even if there is a blockSummary available |
dapplion
approved these changes
Jun 4, 2021
mpetrunic
approved these changes
Jun 4, 2021
wemeetagain
approved these changes
Jun 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were cases when I was testing the weak subjectivity state fetching where I couldn't get a very recently finalized state by its slot. The
debug/statewould not fetch the state if we couldn't find a block summary in the fork choice and it wouldn't trigger the state API's state regen functionality. This PR extends the existing solution to regen a state regardless of whether a block summary is found.