-
-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve validator exit flow #2695
Conversation
Code Climate has analyzed commit 842e889 and detected 8 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome performance boost! Tho I think it would be simpler to refactor the ValidatorExitProcess into a BlockProcess
and make it mandatory param in the function signature.
f354c59
to
40b767a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Nice perf boost 🚀 We should add a benchmark for attester slashing and proposer slashing too
Motivation
Description
ValidatorExitProcess
) per block to make sure we loop through it at most 1 timeinitiateValidatorExit
block.perf.ts
is reduced from 100x to 6x, notice that processing 1 validator exit takes almost the same time to processing 16 validator exitsCloses #2342