Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IndexedSyncCommittee #2700

Merged
merged 5 commits into from
Jun 15, 2021
Merged

IndexedSyncCommittee #2700

merged 5 commits into from
Jun 15, 2021

Conversation

twoeths
Copy link
Contributor

@twoeths twoeths commented Jun 15, 2021

Motivation

  • Currently we have sync committee in state and its indexed data in epoch context
  • We want to manage and update them in a single place

Description

  • Create IndexedSyncComittee with indexed data inside, store it in CachedBeaconState
  • Use the same instance per normal epoch transition
  • Do rotateSyncCommittee per sync committee period transition
  • Sync speed is the same to master when I sync oonoonba

Closes #2518

@codeclimate
Copy link

codeclimate bot commented Jun 15, 2021 •
edited
Loading

Code Climate has analyzed commit b01bcb6 and detected 7 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 5
Duplication 2

View more on Code Climate.

@twoeths twoeths marked this pull request as ready for review June 15, 2021 09:58
dapplion
dapplion approved these changes Jun 15, 2021
View reviewed changes
Copy link
Contributor

@dapplion dapplion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 👍

wemeetagain
wemeetagain approved these changes Jun 15, 2021
View reviewed changes
Copy link
Member

@wemeetagain wemeetagain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 lgtm

@wemeetagain wemeetagain merged commit ba9c7c1 into master Jun 15, 2021
@wemeetagain wemeetagain deleted the tuyen/indexed-sync-committee branch June 15, 2021 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dapplion dapplion dapplion approved these changes

@wemeetagain wemeetagain wemeetagain approved these changes

@mpetrunic mpetrunic Awaiting requested review from mpetrunic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create IndexedSyncCommittee
3 participants
@twoeths @wemeetagain @dapplion