-
-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove stale badges #2743
remove stale badges #2743
Conversation
Code Climate has analyzed commit 601cb35 and detected 0 issues on this pull request. View more on Code Climate. |
As a followup, we should add a badge for the github action |
packages/lodestar/README.md
Outdated
@@ -1,6 +1,5 @@ | |||
# Lodestar | |||
|
|||
[![](https://img.shields.io/travis/com/ChainSafe/lodestar/master.svg?label=master&logo=travis "Master Branch (Travis)")](https://travis-ci.com/ChainSafe/lodestar) | |||
[![Discord](https://img.shields.io/discord/593655374469660673.svg?label=Discord&logo=discord)](https://discord.gg/aMxzVcr) | |||
![ETH2.0_Spec_Version 0.12.1](https://img.shields.io/badge/ETH2.0_Spec_Version-0.12.1-2e86c1.svg) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there's still some stale badges
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you think we should remove that eth2 spec version badge? on one hand, we'd have to update it every so often, but on the other hand, it might be a good thing to keep us in check and make sure we actually are up to spec. if we wanna keep it, i can go through the past version tags in https://github.com/ethereum/eth2.0-specs/tags since 0.12.1 and make sure we are up to spec (unless you already know if we are or not).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could just bump them all to 1.0.0, and once the altair release is locked down, then bump to 1.1.0
Performance Report✔️ no performance regression detected Full benchmark results
|
part of #2729