Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove stale badges #2743

Merged
merged 2 commits into from
Jun 29, 2021
Merged

remove stale badges #2743

merged 2 commits into from
Jun 29, 2021

Conversation

3xtr4t3rr3str14l
Copy link
Contributor

part of #2729

@codeclimate
Copy link

codeclimate bot commented Jun 23, 2021

Code Climate has analyzed commit 601cb35 and detected 0 issues on this pull request.

View more on Code Climate.

@wemeetagain
Copy link
Member

As a followup, we should add a badge for the github action

@@ -1,6 +1,5 @@
# Lodestar

[![](https://img.shields.io/travis/com/ChainSafe/lodestar/master.svg?label=master&logo=travis "Master Branch (Travis)")](https://travis-ci.com/ChainSafe/lodestar)
[![Discord](https://img.shields.io/discord/593655374469660673.svg?label=Discord&logo=discord)](https://discord.gg/aMxzVcr)
![ETH2.0_Spec_Version 0.12.1](https://img.shields.io/badge/ETH2.0_Spec_Version-0.12.1-2e86c1.svg)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's still some stale badges

Copy link
Contributor Author

@3xtr4t3rr3str14l 3xtr4t3rr3str14l Jun 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you think we should remove that eth2 spec version badge? on one hand, we'd have to update it every so often, but on the other hand, it might be a good thing to keep us in check and make sure we actually are up to spec. if we wanna keep it, i can go through the past version tags in https://github.com/ethereum/eth2.0-specs/tags since 0.12.1 and make sure we are up to spec (unless you already know if we are or not).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could just bump them all to 1.0.0, and once the altair release is locked down, then bump to 1.1.0

@github-actions
Copy link
Contributor

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 1fd5724 Previous: 86f9cf2 Ratio
Process block - 250000 vs - with 0 validator exit 6.1025 ms/op 5.9033 ms/op 1.03
Process block - 250000 vs - with 1 validator exit 26.347 ms/op 26.176 ms/op 1.01
Process block - 250000 vs - with 16 validator exits 28.390 ms/op 26.550 ms/op 1.07
epoch - 250000 vs - processJustificationAndFinalization 122.87 us/op 121.67 us/op 1.01
epoch - 250000 vs - processRewardsAndPenalties 390.08 ms/op 360.27 ms/op 1.08
epoch - 250000 vs - processRegistryUpdates 11.070 us/op 10.913 us/op 1.01
epoch - 250000 vs - processSlashings 3.7764 ms/op 3.7023 ms/op 1.02
epoch - 250000 vs - processFinalUpdates 41.522 ms/op 40.482 ms/op 1.03
epoch - 250000 vs - prepareEpochProcessState 1.1278 s/op 1.0540 s/op 1.07
getAttestationDeltas - 250000 vs 175.05 ms/op 167.71 ms/op 1.04
processSlots - 250000 vs - 32 empty slots 2.1340 s/op 2.0508 s/op 1.04
shuffle list - 512 els 1.5461 ms/op 1.5719 ms/op 0.98
shuffle list - 16384 els 17.479 ms/op 17.542 ms/op 1.00
shuffle list - 250000 els 244.33 ms/op 245.94 ms/op 0.99
aggregationBits - 2048 els - readonlyValues 272.02 us/op 273.42 us/op 0.99
aggregationBits - 2048 els - zipIndexesInBitList 57.892 us/op 59.072 us/op 0.98
ssz.Root.equals 1.4190 us/op 1.3360 us/op 1.06
ssz.Root.equals with valueOf() 1.9840 us/op 1.7970 us/op 1.10
byteArrayEquals with valueOf() 1.8850 us/op 1.6790 us/op 1.12

by benchmarkbot/action

@wemeetagain wemeetagain merged commit 89732ad into master Jun 29, 2021
@wemeetagain wemeetagain deleted the P0/stale-badges branch June 29, 2021 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants