Fix broken webpack build in browser #2752
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Lightclient UI build emits warnings when trying to import .d.ts files with a require statement.
https://github.com/ChainSafe/eth2-light-client-demo/runs/2914224290
Description
Change how the config presets are imported to match
lodestar-params
lodestar/packages/params/src/activePreset.ts
Lines 11 to 20 in dc16c5a
It does not cause the warnings anymore, and does not need using a dynamic require statement.
Note that the
ACTIVE_PRESET
env technically arbitrary so it's a bit fishy to have a dynamic non-controlled import there when it's not strictly necessary.