Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove relative import #2761

Merged
merged 1 commit into from
Jun 28, 2021
Merged

Remove relative import #2761

merged 1 commit into from
Jun 28, 2021

Conversation

wemeetagain
Copy link
Member

Bug report from discord:

yorick@ethlinux:~/eth-docker-devel$ docker-compose run --rm consensus --help
internal/modules/cjs/loader.js:905
  throw err;
  ^

Error: Cannot find module '../../../../beacon-state-transition/lib'

@codeclimate
Copy link

codeclimate bot commented Jun 28, 2021

Code Climate has analyzed commit b36eedc and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor

@dapplion dapplion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should finish and merge #2193

@github-actions
Copy link
Contributor

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 081b81b Previous: 3847e25 Ratio
Process block - 250000 vs - with 0 validator exit 6.6212 ms/op 5.9522 ms/op 1.11
Process block - 250000 vs - with 1 validator exit 25.925 ms/op 23.955 ms/op 1.08
Process block - 250000 vs - with 16 validator exits 26.796 ms/op 24.984 ms/op 1.07
epoch - 250000 vs - processJustificationAndFinalization 104.20 us/op 99.298 us/op 1.05
epoch - 250000 vs - processRewardsAndPenalties 379.05 ms/op 357.21 ms/op 1.06
epoch - 250000 vs - processRegistryUpdates 10.111 us/op 9.5550 us/op 1.06
epoch - 250000 vs - processSlashings 3.9085 ms/op 3.7139 ms/op 1.05
epoch - 250000 vs - processFinalUpdates 45.155 ms/op 41.767 ms/op 1.08
epoch - 250000 vs - prepareEpochProcessState 1.0095 s/op 936.26 ms/op 1.08
getAttestationDeltas - 250000 vs 173.28 ms/op 164.85 ms/op 1.05
processSlots - 250000 vs - 32 empty slots 2.0041 s/op 1.8513 s/op 1.08
shuffle list - 512 els 1.5668 ms/op 1.4748 ms/op 1.06
shuffle list - 16384 els 18.488 ms/op 17.072 ms/op 1.08
shuffle list - 250000 els 267.68 ms/op 247.85 ms/op 1.08
aggregationBits - 2048 els - readonlyValues 276.72 us/op 261.94 us/op 1.06
aggregationBits - 2048 els - zipIndexesInBitList 52.000 us/op 50.706 us/op 1.03
ssz.Root.equals 1.5090 us/op 1.3550 us/op 1.11
ssz.Root.equals with valueOf() 1.9190 us/op 1.6810 us/op 1.14
byteArrayEquals with valueOf() 1.7630 us/op 1.6560 us/op 1.06

by benchmarkbot/action

@wemeetagain wemeetagain merged commit a6dd6dd into master Jun 28, 2021
@wemeetagain wemeetagain deleted the cayman/fix-relative-import branch June 28, 2021 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants