Move CLI script to .sh file #2893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapplion
requested review from
mpetrunic,
twoeths and
wemeetagain
as code owners
Merged
|
Code Climate has analyzed commit 828cd34 and detected 0 issues on this pull request. View more on Code Climate. |
Performance Report✔️ no performance regression detected Full benchmark results
|
mpetrunic
approved these changes
Jul 27, 2021
twoeths
approved these changes
Jul 27, 2021
wemeetagain
approved these changes
Jul 27, 2021
There was a problem hiding this comment.
@dapplion in chat:
From running testnets for +1 month we consistently stay in the 3.5-4.5GB and only leave it when something really bad happens
In that case the node should die and not drag along
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Remove cli link in package.json. Running the node through yarn is very problematic because signals are not properly propagated potentially causing zombie processes.
Description
This script forces people to not use yarn to run this command, so signal handling is fine. It replaces the existing soft link so it can also extend the memory limit of node.