-
-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add merge fork types #3090
Merged
Merged
Add merge fork types #3090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Climate has analyzed commit c75b325 and detected 4 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
dapplion
force-pushed
the
dapplion/merge-types
branch
from
September 14, 2021 20:00
f7e2ce7
to
6a97d19
Compare
github-actions
bot
added
mod1-beaconchain
scope-networking
All issues related to networking, gossip, and libp2p.
labels
Sep 14, 2021
Performance Report✔️ no performance regression detected Full benchmark results
|
dapplion
requested review from
mpetrunic,
twoeths and
wemeetagain
as code owners
September 14, 2021 20:16
Codecov Report
@@ Coverage Diff @@
## master #3090 +/- ##
==========================================
- Coverage 58.78% 58.31% -0.48%
==========================================
Files 374 374
Lines 9091 9509 +418
Branches 1348 1489 +141
==========================================
+ Hits 5344 5545 +201
- Misses 3365 3581 +216
- Partials 382 383 +1 |
wemeetagain
previously approved these changes
Sep 14, 2021
wemeetagain
approved these changes
Sep 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Part of #3076
Requires ChainSafe/ssz#185
Description
Closes #3093