Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle fork as uppercase in API #3091

Merged
merged 1 commit into from
Sep 7, 2021
Merged

Handle fork as uppercase in API #3091

merged 1 commit into from
Sep 7, 2021

Conversation

dapplion
Copy link
Contributor

@dapplion dapplion commented Sep 7, 2021

Motivation

Teku returns fork as UPPERCASE

Description

Convert fork to lowercase before using as object index key

@codeclimate
Copy link

codeclimate bot commented Sep 7, 2021

Code Climate has analyzed commit d61a5ec and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Sep 7, 2021

Codecov Report

Merging #3091 (f8c5291) into master (4fee784) will increase coverage by 2.17%.
The diff coverage is n/a.

❗ Current head f8c5291 differs from pull request most recent head d61a5ec. Consider uploading reports for the commit d61a5ec to get more accurate results

@@            Coverage Diff             @@
##           master    #3091      +/-   ##
==========================================
+ Coverage   57.54%   59.72%   +2.17%     
==========================================
  Files         335      376      +41     
  Lines        8371     8958     +587     
  Branches     1278     1320      +42     
==========================================
+ Hits         4817     5350     +533     
- Misses       3185     3225      +40     
- Partials      369      383      +14     

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2021

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: f8c5291 Previous: 392b3d2 Ratio
BeaconState.hashTreeRoot - No change 722.00 ns/op 811.00 ns/op 0.89
BeaconState.hashTreeRoot - 1 full validator 89.033 us/op 87.886 us/op 1.01
BeaconState.hashTreeRoot - 32 full validator 1.2605 ms/op 1.2926 ms/op 0.98
BeaconState.hashTreeRoot - 512 full validator 15.745 ms/op 16.226 ms/op 0.97
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 92.350 us/op 86.247 us/op 1.07
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 1.3644 ms/op 1.1994 ms/op 1.14
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 19.559 ms/op 18.846 ms/op 1.04
BeaconState.hashTreeRoot - 1 balances 60.668 us/op 65.289 us/op 0.93
BeaconState.hashTreeRoot - 32 balances 550.93 us/op 538.13 us/op 1.02
BeaconState.hashTreeRoot - 512 balances 5.1314 ms/op 5.5732 ms/op 0.92
BeaconState.hashTreeRoot - 250000 balances 98.909 ms/op 96.837 ms/op 1.02
processSlot - 1 slots 54.751 us/op 43.792 us/op 1.25
processSlot - 32 slots 2.6511 ms/op 2.3575 ms/op 1.12
getCommitteeAssignments - req 1 vs - 250000 vc 4.5736 ms/op 5.6198 ms/op 0.81
getCommitteeAssignments - req 100 vs - 250000 vc 6.6009 ms/op 7.7462 ms/op 0.85
getCommitteeAssignments - req 1000 vs - 250000 vc 6.9533 ms/op 8.8022 ms/op 0.79
computeProposers - vc 250000 24.175 ms/op 24.165 ms/op 1.00
computeEpochShuffling - vc 250000 185.76 ms/op 223.37 ms/op 0.83
getNextSyncCommittee - vc 250000 392.33 ms/op 382.48 ms/op 1.03
altair processBlock - 250000 vs - 7PWei normalcase 89.751 ms/op 82.077 ms/op 1.09
altair processBlock - 250000 vs - 7PWei worstcase 222.57 ms/op 215.75 ms/op 1.03
altair processEpoch - pyrmont_e62330 493.67 ms/op 490.27 ms/op 1.01
pyrmont_e62330 - altair beforeProcessEpoch 109.80 ms/op 100.39 ms/op 1.09
pyrmont_e62330 - altair processJustificationAndFinalization 114.94 us/op 98.750 us/op 1.16
pyrmont_e62330 - altair processInactivityUpdates 71.792 ms/op 77.491 ms/op 0.93
pyrmont_e62330 - altair processRewardsAndPenalties 59.517 ms/op 59.414 ms/op 1.00
pyrmont_e62330 - altair processRegistryUpdates 20.943 us/op 19.573 us/op 1.07
pyrmont_e62330 - altair processSlashings 5.5050 us/op 4.6590 us/op 1.18
pyrmont_e62330 - altair processEth1DataReset 4.4050 us/op 4.5580 us/op 0.97
pyrmont_e62330 - altair processEffectiveBalanceUpdates 5.0130 ms/op 6.0481 ms/op 0.83
pyrmont_e62330 - altair processSlashingsReset 32.958 us/op 25.359 us/op 1.30
pyrmont_e62330 - altair processRandaoMixesReset 43.248 us/op 36.745 us/op 1.18
pyrmont_e62330 - altair processHistoricalRootsUpdate 6.5200 us/op 6.3660 us/op 1.02
pyrmont_e62330 - altair processParticipationFlagUpdates 46.049 ms/op 53.906 ms/op 0.85
pyrmont_e62330 - altair processSyncCommitteeUpdates 4.7640 us/op 4.3230 us/op 1.10
pyrmont_e62330 - altair afterProcessEpoch 130.29 ms/op 127.09 ms/op 1.03
altair processInactivityUpdates - 250000 normalcase 186.74 ms/op 211.63 ms/op 0.88
altair processInactivityUpdates - 250000 worstcase 187.38 ms/op 210.09 ms/op 0.89
altair processParticipationFlagUpdates - 250000 anycase 86.610 ms/op 99.819 ms/op 0.87
altair processRewardsAndPenalties - 250000 normalcase 116.53 ms/op 138.04 ms/op 0.84
altair processRewardsAndPenalties - 250000 worstcase 129.24 ms/op 125.64 ms/op 1.03
altair processSyncCommitteeUpdates - 250000 410.81 ms/op 409.43 ms/op 1.00
Tree 40 250000 create 514.96 ms/op 500.87 ms/op 1.03
Tree 40 250000 get(125000) 257.16 ns/op 305.45 ns/op 0.84
Tree 40 250000 set(125000) 1.6014 us/op 1.6293 us/op 0.98
Tree 40 250000 toArray() 38.811 ms/op 41.478 ms/op 0.94
Tree 40 250000 iterate all - toArray() + loop 41.247 ms/op 38.003 ms/op 1.09
Tree 40 250000 iterate all - get(i) 104.65 ms/op 113.18 ms/op 0.92
MutableVector 250000 create 25.094 ms/op 21.235 ms/op 1.18
MutableVector 250000 get(125000) 13.610 ns/op 14.234 ns/op 0.96
MutableVector 250000 set(125000) 517.19 ns/op 532.54 ns/op 0.97
MutableVector 250000 toArray() 7.3290 ms/op 7.5923 ms/op 0.97
MutableVector 250000 iterate all - toArray() + loop 7.3404 ms/op 7.9217 ms/op 0.93
MutableVector 250000 iterate all - get(i) 3.1403 ms/op 3.4889 ms/op 0.90
Array 250000 create 4.4844 ms/op 5.1484 ms/op 0.87
Array 250000 clone - spread 1.6386 ms/op 1.7755 ms/op 0.92
Array 250000 get(125000) 0.74500 ns/op 1.2990 ns/op 0.57
Array 250000 set(125000) 0.76900 ns/op 0.90700 ns/op 0.85
Array 250000 iterate all - loop 122.02 us/op 191.63 us/op 0.64
aggregationBits - 2048 els - readonlyValues 199.56 us/op 252.57 us/op 0.79
aggregationBits - 2048 els - zipIndexesInBitList 37.210 us/op 40.286 us/op 0.92
ssz.Root.equals 1.1800 us/op 1.3680 us/op 0.86
ssz.Root.equals with valueOf() 1.4270 us/op 1.5330 us/op 0.93
byteArrayEquals with valueOf() 1.4000 us/op 1.5160 us/op 0.92
phase0 processBlock - 250000 vs - 7PWei normalcase 13.166 ms/op 13.327 ms/op 0.99
phase0 processBlock - 250000 vs - 7PWei worstcase 87.752 ms/op 80.565 ms/op 1.09
phase0 afterProcessEpoch - 250000 vs - 7PWei 207.95 ms/op 228.75 ms/op 0.91
phase0 beforeProcessEpoch - 250000 vs - 7PWei 626.04 ms/op 546.46 ms/op 1.15
phase0 processEpoch - mainnet_e58758 820.56 ms/op 803.38 ms/op 1.02
mainnet_e58758 - phase0 beforeProcessEpoch 506.84 ms/op 416.44 ms/op 1.22
mainnet_e58758 - phase0 processJustificationAndFinalization 117.96 us/op 106.97 us/op 1.10
mainnet_e58758 - phase0 processRewardsAndPenalties 80.320 ms/op 89.920 ms/op 0.89
mainnet_e58758 - phase0 processRegistryUpdates 97.309 us/op 66.692 us/op 1.46
mainnet_e58758 - phase0 processSlashings 5.7050 us/op 4.3540 us/op 1.31
mainnet_e58758 - phase0 processEth1DataReset 5.4450 us/op 4.1380 us/op 1.32
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 5.7922 ms/op 6.3351 ms/op 0.91
mainnet_e58758 - phase0 processSlashingsReset 32.032 us/op 19.559 us/op 1.64
mainnet_e58758 - phase0 processRandaoMixesReset 43.092 us/op 33.848 us/op 1.27
mainnet_e58758 - phase0 processHistoricalRootsUpdate 6.6800 us/op 5.5880 us/op 1.20
mainnet_e58758 - phase0 processParticipationRecordUpdates 28.309 us/op 24.099 us/op 1.17
mainnet_e58758 - phase0 afterProcessEpoch 182.28 ms/op 200.42 ms/op 0.91
phase0 processEffectiveBalanceUpdates - 250000 normalcase 6.6428 ms/op 7.4656 ms/op 0.89
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 1.5489 s/op 1.3272 s/op 1.17
phase0 processRegistryUpdates - 250000 normalcase 98.115 us/op 74.080 us/op 1.32
phase0 processRegistryUpdates - 250000 badcase_full_deposits 4.3113 ms/op 3.5106 ms/op 1.23
phase0 processRegistryUpdates - 250000 worstcase 0.5 2.0997 s/op 1.7064 s/op 1.23
phase0 getAttestationDeltas - 250000 normalcase 37.412 ms/op 40.920 ms/op 0.91
phase0 getAttestationDeltas - 250000 worstcase 37.668 ms/op 41.328 ms/op 0.91
phase0 processSlashings - 250000 worstcase 38.807 ms/op 38.062 ms/op 1.02
shuffle list - 16384 els 13.590 ms/op 15.244 ms/op 0.89
shuffle list - 250000 els 186.73 ms/op 216.94 ms/op 0.86
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 2.5530 ms/op 2.2892 ms/op 1.12
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 988.95 us/op 1.0658 ms/op 0.93
BLS verify - blst-native 1.9977 ms/op 2.0958 ms/op 0.95
BLS verifyMultipleSignatures 3 - blst-native 3.9208 ms/op 4.3176 ms/op 0.91
BLS verifyMultipleSignatures 8 - blst-native 8.6121 ms/op 9.5852 ms/op 0.90
BLS verifyMultipleSignatures 32 - blst-native 29.522 ms/op 33.808 ms/op 0.87
BLS aggregatePubkeys 32 - blst-native 41.754 us/op 45.192 us/op 0.92
BLS aggregatePubkeys 128 - blst-native 159.26 us/op 177.27 us/op 0.90
getAttestationsForBlock 76.340 ms/op 83.474 ms/op 0.91
CheckpointStateCache - add get delete 18.416 us/op 17.319 us/op 1.06
validate gossip signedAggregateAndProof - struct 5.1813 ms/op 5.1327 ms/op 1.01
validate gossip signedAggregateAndProof - treeBacked 4.5593 ms/op 5.0139 ms/op 0.91
validate gossip attestation - struct 2.1388 ms/op 2.3603 ms/op 0.91
validate gossip attestation - treeBacked 2.2177 ms/op 2.3708 ms/op 0.94

by benchmarkbot/action

@dapplion dapplion merged commit 158e5f2 into master Sep 7, 2021
@dapplion dapplion deleted the dapplion/api-fork branch September 7, 2021 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants