Avoid getTotalBalance() #3096
Merged
Avoid getTotalBalance() #3096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 68b968d and detected 0 issues on this pull request. View more on Code Climate. |
Performance Report✔️ no performance regression detected Full benchmark results
|
Codecov Report
@@ Coverage Diff @@
## master #3096 +/- ##
==========================================
- Coverage 59.72% 58.26% -1.47%
==========================================
Files 376 379 +3
Lines 8958 9416 +458
Branches 1320 1412 +92
==========================================
+ Hits 5350 5486 +136
- Misses 3225 3544 +319
- Partials 383 386 +3 |
twoeths
requested review from
dapplion,
mpetrunic and
wemeetagain
as code owners
|
Oh nice pick, but why is the node computing the weak subjectivity period every epoch? Why does it need that info? EDIT: Oh, for the lightclient initer |
dapplion
approved these changes
Sep 9, 2021
wemeetagain
approved these changes
Sep 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
getTotalBalanceis called per finalized checkpoint, basically it means per epochgetTotalBalanceis very slow, it's >3s in the below profiler in my local environment (and usually the server is 2x slower than my environment)Description
totalActiveBalanceByIncrementis available for epochProcess and altair, we should calculate, use it and cache it in EpochContext for both phase0 and altair