Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switching off exemplar in queries #3114

Merged
merged 1 commit into from
Sep 12, 2021
Merged

Conversation

g11tech
Copy link
Contributor

@g11tech g11tech commented Sep 12, 2021

Motivation
We get 404 not found in the grafana queries on some instances for queries which have exemplar feature on for query fetch in dashboard panels.
Switching off the exemplar fetches for these queries, since we don't currently use this feature.

Description

Closes #issue_number

Steps to test or reproduce

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


gajinder seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codeclimate
Copy link

codeclimate bot commented Sep 12, 2021

Code Climate has analyzed commit 416aae6 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor

@dapplion dapplion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks, please post here once you confirm this fixes the 404 issue

@codecov
Copy link

codecov bot commented Sep 12, 2021

Codecov Report

Merging #3114 (416aae6) into master (6fae286) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3114   +/-   ##
=======================================
  Coverage   59.06%   59.06%           
=======================================
  Files         377      377           
  Lines        9067     9067           
  Branches     1336     1336           
=======================================
  Hits         5355     5355           
  Misses       3329     3329           
  Partials      383      383           

@g11tech
Copy link
Contributor Author

g11tech commented Sep 12, 2021

Looks great! Thanks, please post here once you confirm this fixes the 404 issue

yes, already tested.

@dapplion dapplion merged commit 2c9ebf7 into ChainSafe:master Sep 12, 2021
@q9f q9f added status5-mergeready scope-metrics All issues with regards to the exposed metrics. labels Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope-metrics All issues with regards to the exposed metrics.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants