Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump level db deps #3189

Merged
merged 1 commit into from
Sep 16, 2021
Merged

Bump level db deps #3189

merged 1 commit into from
Sep 16, 2021

Conversation

dapplion
Copy link
Contributor

@dapplion dapplion commented Sep 16, 2021 •
edited
Loading

Motivation

Bundles dependabot changes in one PR

Description

Bump level db deps

@q9f Can you test this PR in bulk? The previous two separate PRs by dependabot were not safe since this modules are tightly coupled. A minimum count of db opts must be perform to ensure this bump is safe, i.e. sync some 5-10 epochs.

This was referenced Sep 16, 2021
Closed
Closed
@codeclimate
Copy link

codeclimate bot commented Sep 16, 2021 •
edited
Loading

Code Climate has analyzed commit 5885ef9 and detected 0 issues on this pull request.

View more on Code Climate.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 16, 2021 •
edited
Loading

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 39d2699 Previous: 2bd1a00 Ratio
BeaconState.hashTreeRoot - No change 840.00 ns/op 708.00 ns/op 1.19
BeaconState.hashTreeRoot - 1 full validator 90.850 us/op 79.663 us/op 1.14
BeaconState.hashTreeRoot - 32 full validator 1.2938 ms/op 1.0894 ms/op 1.19
BeaconState.hashTreeRoot - 512 full validator 17.152 ms/op 14.479 ms/op 1.18
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 89.693 us/op 75.633 us/op 1.19
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 1.3479 ms/op 1.2489 ms/op 1.08
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 21.027 ms/op 16.298 ms/op 1.29
BeaconState.hashTreeRoot - 1 balances 66.198 us/op 56.357 us/op 1.17
BeaconState.hashTreeRoot - 32 balances 580.50 us/op 494.07 us/op 1.17
BeaconState.hashTreeRoot - 512 balances 5.6987 ms/op 4.7514 ms/op 1.20
BeaconState.hashTreeRoot - 250000 balances 99.845 ms/op 90.794 ms/op 1.10
processSlot - 1 slots 47.311 us/op 40.384 us/op 1.17
processSlot - 32 slots 2.5426 ms/op 2.1317 ms/op 1.19
getCommitteeAssignments - req 1 vs - 250000 vc 6.1541 ms/op 5.1828 ms/op 1.19
getCommitteeAssignments - req 100 vs - 250000 vc 8.5562 ms/op 7.1905 ms/op 1.19
getCommitteeAssignments - req 1000 vs - 250000 vc 9.1092 ms/op 7.6308 ms/op 1.19
computeProposers - vc 250000 25.830 ms/op 20.591 ms/op 1.25
computeEpochShuffling - vc 250000 224.34 ms/op 190.25 ms/op 1.18
getNextSyncCommittee - vc 250000 414.34 ms/op 337.28 ms/op 1.23
altair processBlock - 250000 vs - 7PWei normalcase 91.058 ms/op 73.592 ms/op 1.24
altair processBlock - 250000 vs - 7PWei worstcase 231.40 ms/op 192.49 ms/op 1.20
altair processEpoch - pyrmont_e62330 504.63 ms/op 429.36 ms/op 1.18
pyrmont_e62330 - altair beforeProcessEpoch 167.28 ms/op 142.31 ms/op 1.18
pyrmont_e62330 - altair processJustificationAndFinalization 77.333 us/op 126.18 us/op 0.61
pyrmont_e62330 - altair processInactivityUpdates 9.0123 ms/op 7.6393 ms/op 1.18
pyrmont_e62330 - altair processRewardsAndPenalties 64.370 ms/op 52.983 ms/op 1.21
pyrmont_e62330 - altair processRegistryUpdates 11.149 us/op 16.110 us/op 0.69
pyrmont_e62330 - altair processSlashings 4.2470 us/op 2.7830 us/op 1.53
pyrmont_e62330 - altair processEth1DataReset 3.1520 us/op 2.6180 us/op 1.20
pyrmont_e62330 - altair processEffectiveBalanceUpdates 6.2706 ms/op 5.7686 ms/op 1.09
pyrmont_e62330 - altair processSlashingsReset 17.182 us/op 15.122 us/op 1.14
pyrmont_e62330 - altair processRandaoMixesReset 21.000 us/op 25.515 us/op 0.82
pyrmont_e62330 - altair processHistoricalRootsUpdate 3.6480 us/op 3.1060 us/op 1.17
pyrmont_e62330 - altair processParticipationFlagUpdates 46.914 ms/op 42.919 ms/op 1.09
pyrmont_e62330 - altair processSyncCommitteeUpdates 2.4650 us/op 2.2660 us/op 1.09
pyrmont_e62330 - altair afterProcessEpoch 129.53 ms/op 114.91 ms/op 1.13
altair processInactivityUpdates - 250000 normalcase 71.459 ms/op 59.901 ms/op 1.19
altair processInactivityUpdates - 250000 worstcase 67.621 ms/op 55.991 ms/op 1.21
altair processParticipationFlagUpdates - 250000 anycase 108.21 ms/op 80.230 ms/op 1.35
altair processRewardsAndPenalties - 250000 normalcase 129.70 ms/op 107.09 ms/op 1.21
altair processRewardsAndPenalties - 250000 worstcase 143.47 ms/op 109.96 ms/op 1.30
altair processSyncCommitteeUpdates - 250000 410.14 ms/op 355.32 ms/op 1.15
Tree 40 250000 create 508.76 ms/op 422.66 ms/op 1.20
Tree 40 250000 get(125000) 308.09 ns/op 267.18 ns/op 1.15
Tree 40 250000 set(125000) 1.6110 us/op 1.4200 us/op 1.13
Tree 40 250000 toArray() 43.445 ms/op 35.653 ms/op 1.22
Tree 40 250000 iterate all - toArray() + loop 42.961 ms/op 36.155 ms/op 1.19
Tree 40 250000 iterate all - get(i) 120.60 ms/op 101.83 ms/op 1.18
MutableVector 250000 create 23.033 ms/op 20.645 ms/op 1.12
MutableVector 250000 get(125000) 13.456 ns/op 12.934 ns/op 1.04
MutableVector 250000 set(125000) 565.89 ns/op 528.17 ns/op 1.07
MutableVector 250000 toArray() 7.7816 ms/op 8.2894 ms/op 0.94
MutableVector 250000 iterate all - toArray() + loop 8.0503 ms/op 7.4996 ms/op 1.07
MutableVector 250000 iterate all - get(i) 3.3973 ms/op 3.4568 ms/op 0.98
Array 250000 create 5.3157 ms/op 4.6826 ms/op 1.14
Array 250000 clone - spread 2.1398 ms/op 1.7530 ms/op 1.22
Array 250000 get(125000) 1.2440 ns/op 1.1070 ns/op 1.12
Array 250000 set(125000) 0.92000 ns/op 1.1010 ns/op 0.84
Array 250000 iterate all - loop 194.04 us/op 168.25 us/op 1.15
aggregationBits - 2048 els - readonlyValues 305.07 us/op 235.84 us/op 1.29
aggregationBits - 2048 els - zipIndexesInBitList 50.977 us/op 39.559 us/op 1.29
ssz.Root.equals 1.5560 us/op 1.2610 us/op 1.23
ssz.Root.equals with valueOf() 1.8850 us/op 1.4190 us/op 1.33
byteArrayEquals with valueOf() 1.7760 us/op 1.3940 us/op 1.27
phase0 processBlock - 250000 vs - 7PWei normalcase 13.305 ms/op 11.507 ms/op 1.16
phase0 processBlock - 250000 vs - 7PWei worstcase 87.787 ms/op 74.008 ms/op 1.19
phase0 afterProcessEpoch - 250000 vs - 7PWei 244.14 ms/op 211.13 ms/op 1.16
phase0 beforeProcessEpoch - 250000 vs - 7PWei 637.03 ms/op 524.46 ms/op 1.21
phase0 processEpoch - mainnet_e58758 830.87 ms/op 772.23 ms/op 1.08
mainnet_e58758 - phase0 beforeProcessEpoch 515.92 ms/op 469.72 ms/op 1.10
mainnet_e58758 - phase0 processJustificationAndFinalization 70.197 us/op 88.611 us/op 0.79
mainnet_e58758 - phase0 processRewardsAndPenalties 91.787 ms/op 91.134 ms/op 1.01
mainnet_e58758 - phase0 processRegistryUpdates 50.876 us/op 79.549 us/op 0.64
mainnet_e58758 - phase0 processSlashings 2.7480 us/op 2.8350 us/op 0.97
mainnet_e58758 - phase0 processEth1DataReset 2.9840 us/op 2.3760 us/op 1.26
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 9.5800 ms/op 9.5948 ms/op 1.00
mainnet_e58758 - phase0 processSlashingsReset 14.443 us/op 16.796 us/op 0.86
mainnet_e58758 - phase0 processRandaoMixesReset 32.623 us/op 28.819 us/op 1.13
mainnet_e58758 - phase0 processHistoricalRootsUpdate 4.0520 us/op 2.7050 us/op 1.50
mainnet_e58758 - phase0 processParticipationRecordUpdates 18.520 us/op 19.055 us/op 0.97
mainnet_e58758 - phase0 afterProcessEpoch 213.93 ms/op 183.54 ms/op 1.17
phase0 processEffectiveBalanceUpdates - 250000 normalcase 13.419 ms/op 11.314 ms/op 1.19
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 1.3289 s/op 1.1913 s/op 1.12
phase0 processRegistryUpdates - 250000 normalcase 73.976 us/op 70.788 us/op 1.05
phase0 processRegistryUpdates - 250000 badcase_full_deposits 3.6733 ms/op 3.3809 ms/op 1.09
phase0 processRegistryUpdates - 250000 worstcase 0.5 1.7992 s/op 1.4341 s/op 1.25
phase0 getAttestationDeltas - 250000 normalcase 40.952 ms/op 35.701 ms/op 1.15
phase0 getAttestationDeltas - 250000 worstcase 41.488 ms/op 36.164 ms/op 1.15
phase0 processSlashings - 250000 worstcase 37.863 ms/op 33.598 ms/op 1.13
shuffle list - 16384 els 13.405 ms/op 13.169 ms/op 1.02
shuffle list - 250000 els 216.14 ms/op 188.81 ms/op 1.14
getEffectiveBalances - 250000 vs - 7PWei 13.135 ms/op 10.722 ms/op 1.23
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 1.9735 ms/op 2.1881 ms/op 0.90
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 1.1085 ms/op 962.01 us/op 1.15
BLS verify - blst-native 2.0360 ms/op 1.8577 ms/op 1.10
BLS verifyMultipleSignatures 3 - blst-native 4.0756 ms/op 3.8065 ms/op 1.07
BLS verifyMultipleSignatures 8 - blst-native 8.4684 ms/op 8.2207 ms/op 1.03
BLS verifyMultipleSignatures 32 - blst-native 33.526 ms/op 29.807 ms/op 1.12
BLS aggregatePubkeys 32 - blst-native 46.225 us/op 39.860 us/op 1.16
BLS aggregatePubkeys 128 - blst-native 177.40 us/op 155.61 us/op 1.14
getAttestationsForBlock 83.723 ms/op 71.066 ms/op 1.18
CheckpointStateCache - add get delete 17.651 us/op 14.662 us/op 1.20
validate gossip signedAggregateAndProof - struct 5.2375 ms/op 4.4334 ms/op 1.18
validate gossip signedAggregateAndProof - treeBacked 5.3612 ms/op 4.4137 ms/op 1.21
validate gossip attestation - struct 2.4498 ms/op 2.0757 ms/op 1.18
validate gossip attestation - treeBacked 2.4517 ms/op 2.0809 ms/op 1.18

by benchmarkbot/action

@q9f
Copy link
Contributor

q9f commented Sep 16, 2021

Tests do not build.

@chainsafe/lodestar-params: test/yaml.ts:8:3 - error TS2345: Argument of type '{ include: Schema[]; implicit: Type[]; }' is not assignable to parameter of type 'Type | SchemaDefinition | Type[]'.
@chainsafe/lodestar-params:   Object literal may only specify known properties, and 'include' does not exist in type 'Type | SchemaDefinition | Type[]'.
@chainsafe/lodestar-params: 8   include: [FAILSAFE_SCHEMA],
@chainsafe/lodestar-params:     ~~~~~~~~~~~~~~~~~~~~~~~~~~
@chainsafe/lodestar-params: Found 1 error.
@chainsafe/lodestar-params: error Command failed with exit code 2.
@chainsafe/lodestar-params: info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
@chainsafe/lodestar-params: error Command failed with exit code 2.
@chainsafe/lodestar-params: info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

@dapplion
Copy link
Contributor Author

Right, let me merge this one first #3190

@dapplion
Copy link
Contributor Author

@q9f Should build ok now

@codecov
Copy link

codecov bot commented Sep 16, 2021 •
edited
Loading

Codecov Report

Merging #3189 (5885ef9) into master (97ed917) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3189   +/-   ##
=======================================
  Coverage   58.86%   58.86%           
=======================================
  Files         374      374           
  Lines        9095     9095           
  Branches     1348     1348           
=======================================
  Hits         5354     5354           
  Misses       3358     3358           
  Partials      383      383

@wemeetagain wemeetagain merged commit 90f1ad7 into master Sep 16, 2021
@wemeetagain wemeetagain deleted the dapplion/bump-leveldb branch September 16, 2021 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wemeetagain wemeetagain wemeetagain approved these changes

@mpetrunic mpetrunic Awaiting requested review from mpetrunic

@twoeths twoeths Awaiting requested review from twoeths

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dapplion @q9f @wemeetagain