Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move export keyword below comment #3265

Merged
merged 1 commit into from
Sep 28, 2021
Merged

Move export keyword below comment #3265

merged 1 commit into from
Sep 28, 2021

Conversation

dapplion
Copy link
Contributor

Motivation

Fixes typo from #3262

Description

Move export keyword below comment

@codeclimate
Copy link

codeclimate bot commented Sep 28, 2021

Code Climate has analyzed commit 158600d and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Sep 28, 2021 •
edited
Loading

Codecov Report

Merging #3265 (da17875) into master (1fdb7c1) will not change coverage.
The diff coverage is n/a.

❗ Current head da17875 differs from pull request most recent head 158600d. Consider uploading reports for the commit 158600d to get more accurate results

@@           Coverage Diff           @@
##           master    #3265   +/-   ##
=======================================
  Coverage   38.53%   38.53%           
=======================================
  Files         303      303           
  Lines        7624     7624           
  Branches     1120     1120           
=======================================
  Hits         2938     2938           
  Misses       4553     4553           
  Partials      133      133

@github-actions
Copy link
Contributor

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: da17875 Previous: 1fdb7c1 Ratio
BeaconState.hashTreeRoot - No change 716.00 ns/op 762.00 ns/op 0.94
BeaconState.hashTreeRoot - 1 full validator 95.251 us/op 93.662 us/op 1.02
BeaconState.hashTreeRoot - 32 full validator 1.3324 ms/op 1.3800 ms/op 0.97
BeaconState.hashTreeRoot - 512 full validator 16.615 ms/op 16.545 ms/op 1.00
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 91.174 us/op 98.178 us/op 0.93
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 1.3310 ms/op 1.2631 ms/op 1.05
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 18.602 ms/op 19.067 ms/op 0.98
BeaconState.hashTreeRoot - 1 balances 66.145 us/op 66.355 us/op 1.00
BeaconState.hashTreeRoot - 32 balances 580.43 us/op 587.23 us/op 0.99
BeaconState.hashTreeRoot - 512 balances 5.4459 ms/op 5.3332 ms/op 1.02
BeaconState.hashTreeRoot - 250000 balances 102.96 ms/op 107.34 ms/op 0.96
processSlot - 1 slots 58.684 us/op 61.591 us/op 0.95
processSlot - 32 slots 2.8074 ms/op 2.8675 ms/op 0.98
getCommitteeAssignments - req 1 vs - 250000 vc 5.1231 ms/op 4.7406 ms/op 1.08
getCommitteeAssignments - req 100 vs - 250000 vc 6.9649 ms/op 6.7421 ms/op 1.03
getCommitteeAssignments - req 1000 vs - 250000 vc 7.6394 ms/op 7.3370 ms/op 1.04
computeProposers - vc 250000 23.174 ms/op 23.695 ms/op 0.98
computeEpochShuffling - vc 250000 204.63 ms/op 191.86 ms/op 1.07
getNextSyncCommittee - vc 250000 391.73 ms/op 376.82 ms/op 1.04
altair processAttestation - 250000 vs - 7PWei normalcase 38.644 ms/op 40.905 ms/op 0.94
altair processAttestation - 250000 vs - 7PWei worstcase 45.463 ms/op 48.225 ms/op 0.94
altair processAttestation - setStatus - 1/6 committees join 10.136 ms/op 11.956 ms/op 0.85
altair processAttestation - setStatus - 1/3 committees join 21.234 ms/op 25.316 ms/op 0.84
altair processAttestation - setStatus - 1/2 committees join 34.513 ms/op 42.572 ms/op 0.81
altair processAttestation - setStatus - 2/3 committees join 48.916 ms/op 49.411 ms/op 0.99
altair processAttestation - setStatus - 4/5 committees join 55.775 ms/op 57.425 ms/op 0.97
altair processAttestation - setStatus - 100% committees join 69.926 ms/op 73.943 ms/op 0.95
altair processAttestation - updateEpochParticipants - 1/6 committees join 11.931 ms/op 11.300 ms/op 1.06
altair processAttestation - updateEpochParticipants - 1/3 committees join 21.795 ms/op 23.817 ms/op 0.92
altair processAttestation - updateEpochParticipants - 1/2 committees join 21.748 ms/op 22.662 ms/op 0.96
altair processAttestation - updateEpochParticipants - 2/3 committees join 23.571 ms/op 25.105 ms/op 0.94
altair processAttestation - updateEpochParticipants - 4/5 committees join 24.182 ms/op 26.030 ms/op 0.93
altair processAttestation - updateEpochParticipants - 100% committees join 25.315 ms/op 27.714 ms/op 0.91
altair processAttestation - updateAllStatus 18.895 ms/op 21.090 ms/op 0.90
altair processBlock - 250000 vs - 7PWei normalcase 45.499 ms/op 45.373 ms/op 1.00
altair processBlock - 250000 vs - 7PWei worstcase 138.17 ms/op 133.90 ms/op 1.03
altair processEpoch - pyrmont_e62330 472.41 ms/op 453.64 ms/op 1.04
pyrmont_e62330 - altair beforeProcessEpoch 155.02 ms/op 153.26 ms/op 1.01
pyrmont_e62330 - altair processJustificationAndFinalization 134.01 us/op 171.30 us/op 0.78
pyrmont_e62330 - altair processInactivityUpdates 7.7642 ms/op 8.1919 ms/op 0.95
pyrmont_e62330 - altair processRewardsAndPenalties 56.705 ms/op 55.995 ms/op 1.01
pyrmont_e62330 - altair processRegistryUpdates 25.945 us/op 31.903 us/op 0.81
pyrmont_e62330 - altair processSlashings 6.6950 us/op 11.426 us/op 0.59
pyrmont_e62330 - altair processEth1DataReset 6.7680 us/op 12.257 us/op 0.55
pyrmont_e62330 - altair processEffectiveBalanceUpdates 6.5681 ms/op 5.6590 ms/op 1.16
pyrmont_e62330 - altair processSlashingsReset 36.442 us/op 60.210 us/op 0.61
pyrmont_e62330 - altair processRandaoMixesReset 50.748 us/op 78.565 us/op 0.65
pyrmont_e62330 - altair processHistoricalRootsUpdate 8.4140 us/op 13.426 us/op 0.63
pyrmont_e62330 - altair processParticipationFlagUpdates 47.533 ms/op 45.643 ms/op 1.04
pyrmont_e62330 - altair processSyncCommitteeUpdates 5.8780 us/op 8.7030 us/op 0.68
pyrmont_e62330 - altair afterProcessEpoch 119.85 ms/op 115.39 ms/op 1.04
altair processInactivityUpdates - 250000 normalcase 67.986 ms/op 74.246 ms/op 0.92
altair processInactivityUpdates - 250000 worstcase 64.255 ms/op 68.492 ms/op 0.94
altair processParticipationFlagUpdates - 250000 anycase 96.989 ms/op 104.60 ms/op 0.93
altair processRewardsAndPenalties - 250000 normalcase 115.01 ms/op 111.89 ms/op 1.03
altair processRewardsAndPenalties - 250000 worstcase 113.78 ms/op 111.56 ms/op 1.02
altair processSyncCommitteeUpdates - 250000 429.77 ms/op 408.02 ms/op 1.05
Tree 40 250000 create 481.05 ms/op 584.91 ms/op 0.82
Tree 40 250000 get(125000) 258.74 ns/op 244.12 ns/op 1.06
Tree 40 250000 set(125000) 1.4761 us/op 1.7063 us/op 0.87
Tree 40 250000 toArray() 39.416 ms/op 41.330 ms/op 0.95
Tree 40 250000 iterate all - toArray() + loop 41.421 ms/op 41.377 ms/op 1.00
Tree 40 250000 iterate all - get(i) 114.97 ms/op 107.35 ms/op 1.07
MutableVector 250000 create 23.092 ms/op 25.378 ms/op 0.91
MutableVector 250000 get(125000) 13.739 ns/op 13.287 ns/op 1.03
MutableVector 250000 set(125000) 527.59 ns/op 611.54 ns/op 0.86
MutableVector 250000 toArray() 7.9881 ms/op 7.8298 ms/op 1.02
MutableVector 250000 iterate all - toArray() + loop 7.9343 ms/op 8.0811 ms/op 0.98
MutableVector 250000 iterate all - get(i) 3.6117 ms/op 3.5038 ms/op 1.03
Array 250000 create 4.9566 ms/op 4.9572 ms/op 1.00
Array 250000 clone - spread 2.0112 ms/op 1.9185 ms/op 1.05
Array 250000 get(125000) 0.83200 ns/op 0.87000 ns/op 0.96
Array 250000 set(125000) 1.0120 ns/op 0.93200 ns/op 1.09
Array 250000 iterate all - loop 131.19 us/op 128.62 us/op 1.02
aggregationBits - 2048 els - readonlyValues 237.47 us/op 230.10 us/op 1.03
aggregationBits - 2048 els - zipIndexesInBitList 48.541 us/op 46.808 us/op 1.04
ssz.Root.equals 1.5390 us/op 1.3070 us/op 1.18
ssz.Root.equals with valueOf() 1.6360 us/op 1.5270 us/op 1.07
byteArrayEquals with valueOf() 1.5550 us/op 1.5060 us/op 1.03
phase0 processBlock - 250000 vs - 7PWei normalcase 14.987 ms/op 14.932 ms/op 1.00
phase0 processBlock - 250000 vs - 7PWei worstcase 91.709 ms/op 99.806 ms/op 0.92
phase0 afterProcessEpoch - 250000 vs - 7PWei 209.93 ms/op 211.74 ms/op 0.99
phase0 beforeProcessEpoch - 250000 vs - 7PWei 692.00 ms/op 787.31 ms/op 0.88
phase0 processEpoch - mainnet_e58758 900.67 ms/op 945.84 ms/op 0.95
mainnet_e58758 - phase0 beforeProcessEpoch 540.64 ms/op 582.41 ms/op 0.93
mainnet_e58758 - phase0 processJustificationAndFinalization 120.67 us/op 202.44 us/op 0.60
mainnet_e58758 - phase0 processRewardsAndPenalties 83.119 ms/op 81.993 ms/op 1.01
mainnet_e58758 - phase0 processRegistryUpdates 98.913 us/op 137.22 us/op 0.72
mainnet_e58758 - phase0 processSlashings 6.4450 us/op 12.502 us/op 0.52
mainnet_e58758 - phase0 processEth1DataReset 6.4670 us/op 11.315 us/op 0.57
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 10.460 ms/op 9.2333 ms/op 1.13
mainnet_e58758 - phase0 processSlashingsReset 33.262 us/op 59.399 us/op 0.56
mainnet_e58758 - phase0 processRandaoMixesReset 43.069 us/op 66.827 us/op 0.64
mainnet_e58758 - phase0 processHistoricalRootsUpdate 9.2280 us/op 16.267 us/op 0.57
mainnet_e58758 - phase0 processParticipationRecordUpdates 30.162 us/op 47.664 us/op 0.63
mainnet_e58758 - phase0 afterProcessEpoch 186.72 ms/op 183.33 ms/op 1.02
phase0 processEffectiveBalanceUpdates - 250000 normalcase 11.129 ms/op 10.668 ms/op 1.04
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 1.7018 s/op 1.6390 s/op 1.04
phase0 processRegistryUpdates - 250000 normalcase 108.28 us/op 164.71 us/op 0.66
phase0 processRegistryUpdates - 250000 badcase_full_deposits 4.5837 ms/op 4.3976 ms/op 1.04
phase0 processRegistryUpdates - 250000 worstcase 0.5 2.1667 s/op 2.1943 s/op 0.99
phase0 getAttestationDeltas - 250000 normalcase 35.255 ms/op 38.321 ms/op 0.92
phase0 getAttestationDeltas - 250000 worstcase 36.579 ms/op 36.158 ms/op 1.01
phase0 processSlashings - 250000 worstcase 35.321 ms/op 32.402 ms/op 1.09
shuffle list - 16384 els 12.818 ms/op 12.920 ms/op 0.99
shuffle list - 250000 els 184.07 ms/op 183.87 ms/op 1.00
getEffectiveBalances - 250000 vs - 7PWei 10.878 ms/op 10.318 ms/op 1.05
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 2.0383 ms/op 2.2686 ms/op 0.90
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 978.18 us/op 1.0700 ms/op 0.91
BLS verify - blst-native 2.0895 ms/op 2.3484 ms/op 0.89
BLS verifyMultipleSignatures 3 - blst-native 4.2758 ms/op 4.9304 ms/op 0.87
BLS verifyMultipleSignatures 8 - blst-native 8.9798 ms/op 10.446 ms/op 0.86
BLS verifyMultipleSignatures 32 - blst-native 33.731 ms/op 39.702 ms/op 0.85
BLS aggregatePubkeys 32 - blst-native 45.064 us/op 52.069 us/op 0.87
BLS aggregatePubkeys 128 - blst-native 172.62 us/op 204.81 us/op 0.84
getAttestationsForBlock 82.271 ms/op 85.906 ms/op 0.96
CheckpointStateCache - add get delete 17.572 us/op 16.289 us/op 1.08
validate gossip signedAggregateAndProof - struct 5.0380 ms/op 5.6909 ms/op 0.89
validate gossip signedAggregateAndProof - treeBacked 4.9237 ms/op 5.5892 ms/op 0.88
validate gossip attestation - struct 2.3367 ms/op 2.6605 ms/op 0.88
validate gossip attestation - treeBacked 2.3409 ms/op 2.7241 ms/op 0.86

by benchmarkbot/action

@wemeetagain wemeetagain merged commit ca48f25 into master Sep 28, 2021
@wemeetagain wemeetagain deleted the dapplion/integrate-execution-engine-typo branch September 28, 2021 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g11tech g11tech g11tech approved these changes

@twoeths twoeths twoeths approved these changes

@wemeetagain wemeetagain wemeetagain approved these changes

@mpetrunic mpetrunic Awaiting requested review from mpetrunic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dapplion @wemeetagain @twoeths @g11tech