Discv5: Do not issue FINDNODES right after the start #3429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twoeths
requested review from
dapplion,
mpetrunic and
wemeetagain
as code owners
|
Code Climate has analyzed commit 8dfad5d and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## master #3429 +/- ##
==========================================
- Coverage 38.12% 38.09% -0.03%
==========================================
Files 303 303
Lines 7911 7917 +6
Branches 1219 1220 +1
==========================================
Hits 3016 3016
- Misses 4754 4760 +6
Partials 141 141 |
Performance Report✔️ no performance regression detected Full benchmark results
|
dapplion
reviewed
Nov 15, 2021
twoeths
force-pushed
the
tuyen/first-hearbeat
branch
from
5d75192 to
c5cef29
Compare
dapplion
reviewed
Nov 15, 2021
dapplion
reviewed
Nov 15, 2021
|
@dapplion even through we define |
dapplion
reviewed
Nov 15, 2021
| // Delay the 1st query after starting discv5 | ||
| if (Date.now() - this.discv5StartMs <= this.discv5FirstQueryDelayMs) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
Whitespace after this if please 🙏
dapplion
reviewed
Nov 15, 2021
| @@ -196,6 +202,10 @@ export class PeerDiscovery { | |||
| * Request to find peers. First, looked at cached peers in peerStore | |||
| */ | |||
| private async runFindRandomNodeQuery(): Promise<void> { | |||
| // Delay the 1st query after starting discv5 | |||
There was a problem hiding this comment.
Link to the Github issue that explain why this is necessary
Makes sense, not a problem 👍 but now we can add longer delays if we need that would go beyond the second heartbeat |
dapplion
approved these changes
Nov 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Sometimes we're not able to send/receive discv5 packets successfully right after it starts. Ideally we should investigate discv5 for that, but I found we all
awaitfor the discv5 start process correctly.Description
FINDNODESin the 1st heart beat of peer managerpart of #3423