Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded infura links from codebase #3499

Merged
merged 3 commits into from
Dec 8, 2021
Merged

Conversation

dapplion
Copy link
Contributor

@dapplion dapplion commented Dec 8, 2021

Motivation

Historically for convenience Lodestar has hardcoded Infura URLs and credentials so the eth1 node doesn't have to be setup. Preparing for the merge and better practices this URLs have to be removed

WARNING!: Setups relying on this auto-filled URLs will need to provide an eth1 endpoint of their own after the next release

Description

  • Remove hardcoded infura links from codebase

@codeclimate
Copy link

codeclimate bot commented Dec 8, 2021

Code Climate has analyzed commit 257619a and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Dec 8, 2021

Codecov Report

Merging #3499 (8ee1964) into master (f491e66) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 8ee1964 differs from pull request most recent head 257619a. Consider uploading reports for the commit 257619a to get more accurate results

@@            Coverage Diff             @@
##           master    #3499      +/-   ##
==========================================
- Coverage   37.91%   37.90%   -0.02%     
==========================================
  Files         308      308              
  Lines        8133     8120      -13     
  Branches     1250     1247       -3     
==========================================
- Hits         3084     3078       -6     
+ Misses       4899     4894       -5     
+ Partials      150      148       -2     

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2021

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 8ee1964 Previous: f491e66 Ratio
BeaconState.hashTreeRoot - No change 656.00 ns/op 588.00 ns/op 1.12
BeaconState.hashTreeRoot - 1 full validator 94.882 us/op 75.454 us/op 1.26
BeaconState.hashTreeRoot - 32 full validator 1.2822 ms/op 1.1660 ms/op 1.10
BeaconState.hashTreeRoot - 512 full validator 15.577 ms/op 13.450 ms/op 1.16
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 89.899 us/op 75.513 us/op 1.19
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 1.4630 ms/op 1.3170 ms/op 1.11
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 20.150 ms/op 17.063 ms/op 1.18
BeaconState.hashTreeRoot - 1 balances 64.078 us/op 54.451 us/op 1.18
BeaconState.hashTreeRoot - 32 balances 561.28 us/op 454.35 us/op 1.24
BeaconState.hashTreeRoot - 512 balances 5.1922 ms/op 4.6182 ms/op 1.12
BeaconState.hashTreeRoot - 250000 balances 102.85 ms/op 84.333 ms/op 1.22
processSlot - 1 slots 41.780 us/op 40.023 us/op 1.04
processSlot - 32 slots 2.3717 ms/op 2.1057 ms/op 1.13
getCommitteeAssignments - req 1 vs - 250000 vc 6.3724 ms/op 5.3798 ms/op 1.18
getCommitteeAssignments - req 100 vs - 250000 vc 8.8212 ms/op 7.4940 ms/op 1.18
getCommitteeAssignments - req 1000 vs - 250000 vc 9.5478 ms/op 8.1186 ms/op 1.18
computeProposers - vc 250000 24.697 ms/op 21.587 ms/op 1.14
computeEpochShuffling - vc 250000 217.81 ms/op 189.62 ms/op 1.15
getNextSyncCommittee - vc 250000 399.67 ms/op 357.84 ms/op 1.12
altair processAttestation - 250000 vs - 7PWei normalcase 39.492 ms/op 35.258 ms/op 1.12
altair processAttestation - 250000 vs - 7PWei worstcase 45.857 ms/op 41.013 ms/op 1.12
altair processAttestation - setStatus - 1/6 committees join 10.645 ms/op 9.9773 ms/op 1.07
altair processAttestation - setStatus - 1/3 committees join 21.047 ms/op 19.988 ms/op 1.05
altair processAttestation - setStatus - 1/2 committees join 31.249 ms/op 33.614 ms/op 0.93
altair processAttestation - setStatus - 2/3 committees join 41.651 ms/op 44.668 ms/op 0.93
altair processAttestation - setStatus - 4/5 committees join 50.623 ms/op 54.187 ms/op 0.93
altair processAttestation - setStatus - 100% committees join 64.233 ms/op 68.779 ms/op 0.93
altair processAttestation - updateEpochParticipants - 1/6 committees join 10.246 ms/op 11.043 ms/op 0.93
altair processAttestation - updateEpochParticipants - 1/3 committees join 22.359 ms/op 23.093 ms/op 0.97
altair processAttestation - updateEpochParticipants - 1/2 committees join 26.595 ms/op 25.526 ms/op 1.04
altair processAttestation - updateEpochParticipants - 2/3 committees join 28.700 ms/op 29.008 ms/op 0.99
altair processAttestation - updateEpochParticipants - 4/5 committees join 29.691 ms/op 29.915 ms/op 0.99
altair processAttestation - updateEpochParticipants - 100% committees join 34.337 ms/op 35.825 ms/op 0.96
altair processAttestation - updateAllStatus 21.969 ms/op 20.886 ms/op 1.05
altair processBlock - 250000 vs - 7PWei normalcase 47.895 ms/op 42.736 ms/op 1.12
altair processBlock - 250000 vs - 7PWei worstcase 125.25 ms/op 111.69 ms/op 1.12
altair processEpoch - mainnet_e81889 1.0925 s/op 955.68 ms/op 1.14
mainnet_e81889 - altair beforeProcessEpoch 362.59 ms/op 324.38 ms/op 1.12
mainnet_e81889 - altair processJustificationAndFinalization 81.136 us/op 78.247 us/op 1.04
mainnet_e81889 - altair processInactivityUpdates 20.725 ms/op 18.365 ms/op 1.13
mainnet_e81889 - altair processRewardsAndPenalties 132.23 ms/op 115.23 ms/op 1.15
mainnet_e81889 - altair processRegistryUpdates 8.9760 us/op 9.8240 us/op 0.91
mainnet_e81889 - altair processSlashings 3.0020 us/op 2.8020 us/op 1.07
mainnet_e81889 - altair processEth1DataReset 2.8100 us/op 2.6160 us/op 1.07
mainnet_e81889 - altair processEffectiveBalanceUpdates 13.282 ms/op 12.312 ms/op 1.08
mainnet_e81889 - altair processSlashingsReset 13.174 us/op 17.894 us/op 0.74
mainnet_e81889 - altair processRandaoMixesReset 15.908 us/op 20.884 us/op 0.76
mainnet_e81889 - altair processHistoricalRootsUpdate 3.1640 us/op 3.9970 us/op 0.79
mainnet_e81889 - altair processParticipationFlagUpdates 110.70 ms/op 100.65 ms/op 1.10
mainnet_e81889 - altair processSyncCommitteeUpdates 2.0430 us/op 2.7500 us/op 0.74
mainnet_e81889 - altair afterProcessEpoch 258.58 ms/op 227.18 ms/op 1.14
altair processInactivityUpdates - 250000 normalcase 74.963 ms/op 72.704 ms/op 1.03
altair processInactivityUpdates - 250000 worstcase 74.841 ms/op 72.099 ms/op 1.04
altair processParticipationFlagUpdates - 250000 anycase 116.13 ms/op 83.515 ms/op 1.39
altair processRewardsAndPenalties - 250000 normalcase 132.12 ms/op 116.06 ms/op 1.14
altair processRewardsAndPenalties - 250000 worstcase 150.71 ms/op 120.04 ms/op 1.26
altair processSyncCommitteeUpdates - 250000 425.05 ms/op 372.26 ms/op 1.14
Tree 40 250000 create 518.39 ms/op 613.39 ms/op 0.85
Tree 40 250000 get(125000) 393.95 ns/op 326.04 ns/op 1.21
Tree 40 250000 set(125000) 1.5594 us/op 1.4165 us/op 1.10
Tree 40 250000 toArray() 42.122 ms/op 43.168 ms/op 0.98
Tree 40 250000 iterate all - toArray() + loop 43.548 ms/op 37.568 ms/op 1.16
Tree 40 250000 iterate all - get(i) 137.09 ms/op 118.40 ms/op 1.16
MutableVector 250000 create 24.900 ms/op 26.634 ms/op 0.93
MutableVector 250000 get(125000) 18.742 ns/op 14.327 ns/op 1.31
MutableVector 250000 set(125000) 551.52 ns/op 562.03 ns/op 0.98
MutableVector 250000 toArray() 11.300 ms/op 8.9940 ms/op 1.26
MutableVector 250000 iterate all - toArray() + loop 13.104 ms/op 9.0496 ms/op 1.45
MutableVector 250000 iterate all - get(i) 4.2800 ms/op 3.4264 ms/op 1.25
Array 250000 create 6.1482 ms/op 5.9053 ms/op 1.04
Array 250000 clone - spread 2.2570 ms/op 2.6250 ms/op 0.86
Array 250000 get(125000) 1.1050 ns/op 1.0970 ns/op 1.01
Array 250000 set(125000) 1.1060 ns/op 1.1040 ns/op 1.00
Array 250000 iterate all - loop 200.30 us/op 168.88 us/op 1.19
aggregationBits - 2048 els - readonlyValues 260.85 us/op 251.90 us/op 1.04
aggregationBits - 2048 els - zipIndexesInBitList 44.912 us/op 47.091 us/op 0.95
regular array get 100000 times 78.982 us/op 67.446 us/op 1.17
wrappedArray get 100000 times 78.252 us/op 67.467 us/op 1.16
arrayWithProxy get 100000 times 32.142 ms/op 29.175 ms/op 1.10
ssz.Root.equals 1.2590 us/op 1.2380 us/op 1.02
ssz.Root.equals with valueOf() 1.5800 us/op 1.4970 us/op 1.06
byteArrayEquals with valueOf() 1.4160 us/op 1.4640 us/op 0.97
phase0 processBlock - 250000 vs - 7PWei normalcase 11.471 ms/op 10.979 ms/op 1.04
phase0 processBlock - 250000 vs - 7PWei worstcase 81.142 ms/op 73.652 ms/op 1.10
phase0 afterProcessEpoch - 250000 vs - 7PWei 234.66 ms/op 209.92 ms/op 1.12
phase0 beforeProcessEpoch - 250000 vs - 7PWei 607.08 ms/op 575.07 ms/op 1.06
phase0 processEpoch - mainnet_e58758 849.90 ms/op 777.39 ms/op 1.09
mainnet_e58758 - phase0 beforeProcessEpoch 512.98 ms/op 486.24 ms/op 1.05
mainnet_e58758 - phase0 processJustificationAndFinalization 56.046 us/op 68.604 us/op 0.82
mainnet_e58758 - phase0 processRewardsAndPenalties 91.662 ms/op 82.455 ms/op 1.11
mainnet_e58758 - phase0 processRegistryUpdates 38.855 us/op 41.382 us/op 0.94
mainnet_e58758 - phase0 processSlashings 2.5980 us/op 3.5660 us/op 0.73
mainnet_e58758 - phase0 processEth1DataReset 1.9500 us/op 2.7380 us/op 0.71
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 11.014 ms/op 10.186 ms/op 1.08
mainnet_e58758 - phase0 processSlashingsReset 12.289 us/op 15.637 us/op 0.79
mainnet_e58758 - phase0 processRandaoMixesReset 16.591 us/op 19.208 us/op 0.86
mainnet_e58758 - phase0 processHistoricalRootsUpdate 3.0810 us/op 3.9160 us/op 0.79
mainnet_e58758 - phase0 processParticipationRecordUpdates 11.861 us/op 13.711 us/op 0.87
mainnet_e58758 - phase0 afterProcessEpoch 213.94 ms/op 210.63 ms/op 1.02
phase0 processEffectiveBalanceUpdates - 250000 normalcase 13.089 ms/op 11.305 ms/op 1.16
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 1.1680 s/op 1.2028 s/op 0.97
phase0 processRegistryUpdates - 250000 normalcase 45.178 us/op 43.732 us/op 1.03
phase0 processRegistryUpdates - 250000 badcase_full_deposits 2.8670 ms/op 2.6856 ms/op 1.07
phase0 processRegistryUpdates - 250000 worstcase 0.5 1.6068 s/op 1.5381 s/op 1.04
phase0 getAttestationDeltas - 250000 normalcase 43.750 ms/op 37.836 ms/op 1.16
phase0 getAttestationDeltas - 250000 worstcase 42.878 ms/op 37.782 ms/op 1.13
phase0 processSlashings - 250000 worstcase 35.816 ms/op 32.306 ms/op 1.11
shuffle list - 16384 els 14.712 ms/op 12.905 ms/op 1.14
shuffle list - 250000 els 212.09 ms/op 185.17 ms/op 1.15
getEffectiveBalances - 250000 vs - 7PWei 12.939 ms/op 15.193 ms/op 0.85
computeDeltas 4.1221 ms/op 3.5540 ms/op 1.16
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 2.5828 ms/op 2.4228 ms/op 1.07
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 802.03 us/op 684.15 us/op 1.17
BLS verify - blst-native 2.1498 ms/op 1.8526 ms/op 1.16
BLS verifyMultipleSignatures 3 - blst-native 4.4166 ms/op 3.8137 ms/op 1.16
BLS verifyMultipleSignatures 8 - blst-native 9.5239 ms/op 8.2127 ms/op 1.16
BLS verifyMultipleSignatures 32 - blst-native 34.746 ms/op 29.788 ms/op 1.17
BLS aggregatePubkeys 32 - blst-native 45.724 us/op 39.478 us/op 1.16
BLS aggregatePubkeys 128 - blst-native 175.80 us/op 153.38 us/op 1.15
getAttestationsForBlock 88.068 ms/op 82.811 ms/op 1.06
CheckpointStateCache - add get delete 16.946 us/op 15.851 us/op 1.07
validate gossip signedAggregateAndProof - struct 5.1465 ms/op 4.4654 ms/op 1.15
validate gossip signedAggregateAndProof - treeBacked 5.0984 ms/op 4.4376 ms/op 1.15
validate gossip attestation - struct 2.4131 ms/op 2.0989 ms/op 1.15
validate gossip attestation - treeBacked 2.4803 ms/op 2.1244 ms/op 1.17
Object access 1 prop 0.37700 ns/op 0.36300 ns/op 1.04
Map access 1 prop 0.32200 ns/op 0.27800 ns/op 1.16
Object get x1000 20.050 ns/op 19.492 ns/op 1.03
Map get x1000 1.1740 ns/op 0.95300 ns/op 1.23
Object set x1000 127.81 ns/op 122.01 ns/op 1.05
Map set x1000 76.088 ns/op 83.917 ns/op 0.91
Return object 10000 times 0.43650 ns/op 0.36680 ns/op 1.19
Throw Error 10000 times 6.7905 us/op 5.8901 us/op 1.15

by benchmarkbot/action

@dapplion dapplion merged commit 661e83c into master Dec 8, 2021
@dapplion dapplion deleted the dapplion/infura branch December 8, 2021 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants