-
-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove hardcoded infura links from codebase #3499
Conversation
Code Climate has analyzed commit 257619a and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## master #3499 +/- ##
==========================================
- Coverage 37.91% 37.90% -0.02%
==========================================
Files 308 308
Lines 8133 8120 -13
Branches 1250 1247 -3
==========================================
- Hits 3084 3078 -6
+ Misses 4899 4894 -5
+ Partials 150 148 -2 |
Performance Report✔️ no performance regression detected Full benchmark results
|
Motivation
Historically for convenience Lodestar has hardcoded Infura URLs and credentials so the eth1 node doesn't have to be setup. Preparing for the merge and better practices this URLs have to be removed
WARNING!: Setups relying on this auto-filled URLs will need to provide an eth1 endpoint of their own after the next release
Description