-
-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build if changed script #3543
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapplion
requested review from
g11tech,
mpetrunic,
twoeths and
wemeetagain
as code owners
December 21, 2021 09:39
Code Climate has analyzed commit d769f30 and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## master #3543 +/- ##
=======================================
Coverage 37.56% 37.56%
=======================================
Files 310 310
Lines 8253 8253
Branches 1273 1273
=======================================
Hits 3100 3100
Misses 5005 5005
Partials 148 148 |
twoeths
approved these changes
Dec 21, 2021
Performance Report✔️ no performance regression detected Full benchmark results
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In some setups I'm building in VPS the build command is run many times when no changes have been done.
The current
yarn build
command blindly nukes the build artifacts and does a build from scratch, which take ~2-3 minDescription
If there has been no modification running the script over all packages takes 0.5 sec.
find
is very fast.Caveats