Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BN<>VC interop: Export the active preset to fill missing preset for spec api #3574

Merged
merged 1 commit into from
Jan 6, 2022

Conversation

g11tech
Copy link
Contributor

@g11tech g11tech commented Jan 5, 2022

Motivation
This PR addresses lodestar validator interop with the other clients (LH)

  • As now merge related fields are present in the preset, this PR also picks the active preset to fill for missing fields in the interop spec api.
  • Tested that no additional params need to be specified in the --paramsFile, since default activiation of merge (and other forks like sharding) via MERGE_EPOCH is set to far future and hence shouldn't interfere with the operation of validator if the spec api don't have those fields. This addresses the need to have a better UX as desired in Canot start validator due to INACTIVITY_PENALTY_QUOTIENT_MERGE being undefined #3437

Tested against Lighthouse BN ✔️

Closes #3437

@codeclimate
Copy link

codeclimate bot commented Jan 5, 2022

Code Climate has analyzed commit 0f675e1 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Jan 5, 2022

Codecov Report

Merging #3574 (07d1834) into master (659e3e1) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 07d1834 differs from pull request most recent head 0f675e1. Consider uploading reports for the commit 0f675e1 to get more accurate results

@@            Coverage Diff             @@
##           master    #3574      +/-   ##
==========================================
- Coverage   37.45%   37.43%   -0.02%     
==========================================
  Files         311      311              
  Lines        8296     8307      +11     
  Branches     1283     1286       +3     
==========================================
+ Hits         3107     3110       +3     
- Misses       5041     5049       +8     
  Partials      148      148              

@g11tech g11tech merged commit b77d0b7 into ChainSafe:master Jan 6, 2022
@g11tech g11tech deleted the interopspec branch January 6, 2022 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Canot start validator due to INACTIVITY_PENALTY_QUOTIENT_MERGE being undefined
2 participants